Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed using namespace from DDRegistry.h #25091

Merged
merged 1 commit into from Nov 1, 2018

Conversation

Dr15Jones
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31427/console Started: 2018/11/01 19:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cvuosalo
Copy link
Contributor

cvuosalo commented Nov 1, 2018

+geometry

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Comparison job queued.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 1, 2018

+1

@Dr15Jones for my understanding, is this just aesthetics?

@cmsbuild cmsbuild merged commit a6cc7e6 into cms-sw:master Nov 1, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25091/31427/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992957
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Dr15Jones
Copy link
Contributor Author

@fabiocos wrote "for my understanding, is this just aesthetics?"

It is more than that. Doing a using namespace at file scope moves all the items in that namespace into the 'global' scope. Doing such in a header file is considered to be a very bad idea (which is why the static analyzer spots such cases). Effectively, one is 'infecting' all other header files that include the first header file with the same problem.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 2, 2018

@Dr15Jones ok, as this is an interface I see the issue, there were several cleaning actions in the past as well...

@Dr15Jones Dr15Jones deleted the removeUsingDDRegistryHeader branch November 9, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants