[HGCAL trigger] Update of the general code architecture - 2 #25100
Conversation
…be_algorithms to new directory /backend
…ethod in HGCalVFELinearizationImpl class
…Impl in order to keep history of the thresholdSelect method
…comes from previous class HGCalTriggerCellThresholdCodecImpl, bestChoiceSelectImpl from HGCalTriggerCellBestChoiceCodecImplHGCalTriggerCellBestChoiceCodecImpl class
…class HGCalTriggerCellThresholdCodecImpl
…comes from previous class HGCalTriggerCellThresholdCodecImpl, bestChoiceSelectImpl from HGCalTriggerCellBestChoiceCodecImplHGCalTriggerCellBestChoiceCodecImpl class
…comes from previous class HGCalTriggerCellThresholdCodecImpl, bestChoiceSelectImpl from HGCalTriggerCellBestChoiceCodecImplHGCalTriggerCellBestChoiceCodecImpl class
…onImpl.h HGCalVFESummationImpl.cc
|
The tests are being triggered in jenkins. |
|
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
|
Comparison job queued. |
|
Comparison is ready Comparison Summary:
|
|
All comments in the original PR have been implemented, all checks pass and there is no conflicts. If there is no more comments, could this PR be approved? |
|
+upgrade |
|
+1 |
|
@fabiocos this is ready to go |
|
+operations changes in StandardSequences are coherent with the purpose of the PR |
cmsbuild
added
fully-signed
operations-approved
and removed
operations-pending
pending-signatures
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 test wf 21234 executes the new code |
Copy of #24544 + removing deprecated cfi + fixing MVA conflict
Original PR note
This PR includes important changes of the architecture of the HGCAL TPG code
An overview of this new software architecture had been presented here. It provides a more flexible data flow and also reflects better the current electronics architecture design.
This new infrastructure will facilitate the development of frontend and backend algorithms and also give the possibility to easily run in parallel several trigger workflows.