Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow one::DQMEDAnalyzer to use LuminosityBlockCache #25114

Merged
merged 1 commit into from Nov 5, 2018

Conversation

Dr15Jones
Copy link
Contributor

This extends one::DQMEDAnalyzer to use the new ability of an edm::one module to use a LuminosityBlockCache.

This facility will allow the framework to efficiently processes concurrent LuminosityBlocks.

This extends one::DQMEDAnalyzer to use the new ability of an
edm::one module to use a LuminosityBlockCache
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQMServices/Core

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 2, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31456/console Started: 2018/11/02 22:28

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25114/31456/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992957
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2018

+1

@cmsbuild cmsbuild merged commit ab43c5b into cms-sw:master Nov 5, 2018
@Dr15Jones Dr15Jones deleted the oneDQMEDAnalyzerLumiCache branch November 9, 2018 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants