Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update fragment for MadGraph Workflow at SL7 #25116

Merged
merged 2 commits into from Nov 5, 2018

Conversation

qliphy
Copy link
Contributor

@qliphy qliphy commented Nov 3, 2018

Set SCRAM_ARCH and Release to 'slc6_amd64_gcc530','CMSSW_8_4_0' for several MG workflows (512, 513)

For 562.0 (BulkG_ZZ_2L2Q_M1200_narrow_13TeV_pythia8), it is a bit more complicated, as the original gridpack was made with 7_1_30 and lhapdf 6.2.1. While at 8_X, lhapdf is 6.1.6 which doesn't contain several 4f PDF. Thus I recompile the SysCalc inside the gridpack and repack it, with the details as following, which I think can also be used for other old gridpacks to make them work under SL7:

set an SL6 environment (930 and amd64_gcc630) to recompile SysCalc
LHAPDFCONFIG=echo "$LHAPDF_DATA_PATH/../../bin/lhapdf-config"
PATH=${LHAPDFCONFIG} --prefix/bin:${PATH} make

untar gridpack
replace
mgbasedir/SysCalc/sys_calc

Option: UPDATE cmssw_version and scram_arch_version in runcmsgrid.sh to CMSSW_9_3_0 and slc6_amd64_gcc630

XZ_OPT="--lzma2=preset=9,dict=512MiB" tar -cJpsf YOURS.tar.xz mgbasedir process runcmsgrid.sh gridpack_generation.log InputCards

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

The code-checks are being triggered in jenkins.

@qliphy
Copy link
Contributor Author

qliphy commented Nov 3, 2018

the new gridpack for workflow 562 has been copied to eos but not yet synced to cvmfs, needs to wait for a bit to start the test

/cvmfs/cms.cern.ch/phys_generator/gridpacks/2017/13TeV/madgraph/V5_2.4.2/exo_diboson/Spin_2/BkGraviton_ZZ_inclu_narrow_M1200_slc6_amd64_gcc481_CMSSW_7_1_30_gcc700-10-3-0-Syscalc_tarball.tar.xz

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

A new Pull Request was created by @qliphy (Qiang Li) for master.

It involves the following packages:

Configuration/Generator

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor Author

qliphy commented Nov 3, 2018

please test workflow 512,513,562

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31459/console Started: 2018/11/03 05:05

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

-1

Tested at: 10ab395

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ffd3fff
2a7b21c
39b8483
d3a084e
8c83b1b
c46cb61
159c739
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31459/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31459/git-merge-result

You can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31459/summary.html

I found follow errors while testing this PR

Failed tests: RelVals

  • RelVals:

When I ran the RelVals I found an error in the following worklfows:
562.0 step1

runTheMatrix-results/562.0_BulkG_ZZ_2L2Q_M1200_narrow_13TeV_pythia8+BulkG_M1200_narrow_2L2Q_LHE_13TeV+Hadronizer_TuneCUETP8M1_Mad_pythia8+HARVESTGEN2/step1_BulkG_ZZ_2L2Q_M1200_narrow_13TeV_pythia8+BulkG_M1200_narrow_2L2Q_LHE_13TeV+Hadronizer_TuneCUETP8M1_Mad_pythia8+HARVESTGEN2.log

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
ffd3fff
2a7b21c
39b8483
d3a084e
8c83b1b
c46cb61
159c739
You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31459/git-log-recent-commits
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31459/git-merge-result

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison not run due to runTheMatrix errors (RelVals and Igprof tests were also skipped)

@qliphy
Copy link
Contributor Author

qliphy commented Nov 3, 2018

Workflows 512, 513 are ok. 562 has problem with gcc.
../../bin/internal/gen_ximprove: /usr/lib64/libgfortran.so.3: version `GFORTRAN_1.4' not found (required by ../../bin/internal/gen_ximprove)

My local test at lxplus7.cern.ch indeed worked quite well. However, at lxplus.cern.ch I could reproduce the error. Maybe the checks were done at lxplus..

Anyway I may need to recompile the gridpack in 562 and make sure the local test works.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Pull request #25116 was updated. @alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please check and sign again.

@qliphy
Copy link
Contributor Author

qliphy commented Nov 3, 2018

please test workflow 512,513,562

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31463/console Started: 2018/11/03 14:55

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 3, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25116/31463/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25116/512.0_DYTollJets_LO_Mad_13TeV_py8+DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+HARVESTGEN2
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25116/513.0_WTolNuJets_LO_Mad_13TeV_py8+WTolNu01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV+Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8+HARVESTGEN2
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25116/562.0_BulkG_ZZ_2L2Q_M1200_narrow_13TeV_pythia8+BulkG_M1200_narrow_2L2Q_LHE_13TeV+Hadronizer_TuneCUETP8M1_Mad_pythia8+HARVESTGEN2

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 2993155
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2992957
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Nov 4, 2018

@qliphy thank you, I understand that this is a temporary workaround waiting to move the whole library to the newest Madgraph version. Anyway I think it is good to have, but the failing workflows are definitely more than 3:

https://cmssdt.cern.ch/SDT/html/cmssdt-ib/#/relVal/CMSSW_10_4/2018-11-02-2300?selectedArchs=slc7_amd64_gcc700&selectedFlavors=X&selectedStatus=known_failed

Are you planning to fix all fo them? Or do you already have new gridpacks close to be ready?

@qliphy
Copy link
Contributor Author

qliphy commented Nov 5, 2018

@fabiocos Indeed 515, 518, 522, 526, 529 share the same fragment as 512;
while 516, 519, 521, 525, 528 share with 513.

For several others, like 551, as mentioned before, local test works well, the problem here seems to be timeout.

@qliphy
Copy link
Contributor Author

qliphy commented Nov 5, 2018

For more details:

from
https://github.com/cms-sw/cmssw/blob/CMSSW_10_4_X/Configuration/PyReleaseValidation/python/relval_extendedgen.py
and
https://github.com/cms-sw/cmssw/blob/CMSSW_10_4_X/Configuration/PyReleaseValidation/python/relval_generator.py

you can find workflow 512 and 515 share the same LHE fragment "DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV"

workflows[512]=['DYTollJets_LO_Mad_13TeV_py8',['DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV','Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8','HARVESTGEN2']]

workflows[515]=['DYTollJets_LO_Mad_13TeV_py8_taupinu',['DYToll01234Jets_5f_LO_MLM_Madgraph_LHE_13TeV','Hadronizer_TuneCP5_13TeV_MLM_5f_max4j_LHE_pythia8_taupinu','HARVESTGEN2']]

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2018

@qliphy thank you, are you planning further developments for this PR, or are you ready to sign it for integration?

@qliphy
Copy link
Contributor Author

qliphy commented Nov 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Nov 5, 2018

+1

@cmsbuild cmsbuild merged commit d4347d3 into cms-sw:master Nov 5, 2018
@qliphy
Copy link
Contributor Author

qliphy commented Nov 6, 2018

@fabiocos It works well with slc7_amd64_gcc700. The problem appears under slc6_amd64_gcc700. It seems only updating SysCalc doesn't work (although I don't know why it worked and passed the check yesterday). I have now regenerated the gridpack from scratch and updated it in cvmfs. It should work now, at least local test succeeds with both sl7 and sl6.

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2018

@qliphy we should ensure that it is the CMSSW environment to provide the needed libraries, and not just depend on the occasional differences between installations on one or another machine.
As the gridpack is now new, let's see how it goes in next IB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants