Cleanup DQM/CSCMonitorModule

[Dr15Jones]

-Removed an unnecessary build dependency
-Removed unneeded function declarations in CSCMonitorModule. This will help future code migration.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25124/7121

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/CSCMonitorModule

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@ptcox, @barvic this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[Dr15Jones]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31478/console Started: 2018/11/05 21:16

[cmsbuild]

+1
Tested at: f87ef5e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25124/31478/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25124/31478/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2993155
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 2992957
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[andrius-k]

Hi @Dr15Jones, are you planning to test this PR in playback?

[andrius-k]

Hi @Dr15Jones, are you planning to test this PR in playback?

I presume there will not be a back-port to this PR.

[andrius-k]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[Dr15Jones]

See #25128 (comment) for response to playback and back-port questions.

[fabiocos]

+1

it looks a technical cleaning whose backport to 10_3_X is likely unnecessary