MET EE noise mitigation in 2017 data [remove unnecessary lines]

[eioannou]

A new PR is related to the PR #24876 in which unnecessary lines have already removed from MET tool.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25129/7125

[cmsbuild]

A new Pull Request was created by @eioannou (Emilios Ioannou) for master.

It involves the following packages:

PhysicsTools/PatUtils

@perrotta, @monttj, @cmsbuild, @fgolf, @slava77, @peruzzim can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @rappoccio, @HeinerTholen, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @jdolen, @drkovalskyi, @ferencek, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31483/console Started: 2018/11/05 22:54

[cmsbuild]

+1
Tested at: 26aa548
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25129/31483/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25129/31483/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2473 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 2993155
• DQMHistoTests: Total failures: 8938
• DQMHistoTests: Total nulls: 5
• DQMHistoTests: Total successes: 2984015
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: -0.416 KiB( 31 files compared)
• DQMHistoSizes: changed ( 10224.0 ): -0.416 KiB SiStrip/MechanicalView
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

@eioannou @kpedro88
A lot of differences in workflow 10224 (only that one): any explanation?

[kpedro88]

@perrotta 10224 is a PU workflow, and the differences occur upstream of the changes in this PR. Maybe the pileup input changed or there was some other random number shift?

[perrotta]

The minbias input file used in the baseline and in this PR test is the same. Also logs are identical (warnings, etc.), till step3 at event 10 where in the baseline: ``` %MSG-e SiStripMonitorTrack: SiStripMonitorTrack:HLTSiStripMonitorTrack 05-Nov-2018 14:12:18 CET Run: 1 Event: 10 ClusterCollection is not valid!! %MSG 0(4.7) 1(4.7) 2(4.7) 4(4.7) 5(4.7) 6(4.7) 05-Nov-2018 14:12:35 CET Closed file file:step2.root 05-Nov-2018 14:12:38 CET Closed file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_0_0_pre2/RelValMinBias_13/GEN-SIM/100X_mc2017_realistic_v1-v1/20000/7206FE6B-89DC-E711-8556-0CC47A4C8F06.root ``` and in this PR test ``` %MSG-e SiStripMonitorTrack: SiStripMonitorTrack:HLTSiStripMonitorTrack 06-Nov-2018 00:25:31 CET Run: 1 Event: 10 ClusterCollection is not valid!! %MSG 0(5.75) 1(5.75) 2(5.75) 4(5.75) 5(5.75) 6(5.75) 06-Nov-2018 00:25:58 CET Closed file file:step2.root 06-Nov-2018 00:26:01 CET Closed file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/relval/CMSSW_10_0_0_pre2/RelValMinBias_13/GEN-SIM/100X_mc2017_realistic_v1-v1/20000/7206FE6B-89DC-E711-8556-0CC47A4C8F06.root ``` Maybe this PR is not related, but I would just be curious to understand where the difference comes from, and from where those outputs are originated.

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31536/console Started: 2018/11/08 15:58

[cmsbuild]

+1
Tested at: 26aa548
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25129/31536/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25129/31536/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25129/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013827
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013629
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• There are no differences any more in the comparisons: as expected, they did not originate from this PR
• Lines defining an un-necessary default are removed: tests pass with no changes
• (This complements MET EE noise mitigation in 2017 data #24876, where this commit got simply lost during a rebase)

[fabiocos]

+1

[fabiocos]

merge