Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[103X] Change GT. Update offline GTs. Add 2018 Peak Cosmic Queue. Updated 2018 MC GTs. #25130

Merged
merged 6 commits into from Nov 14, 2018
Merged

[103X] Change GT. Update offline GTs. Add 2018 Peak Cosmic Queue. Updated 2018 MC GTs. #25130

merged 6 commits into from Nov 14, 2018

Conversation

lpernie
Copy link
Contributor

@lpernie lpernie commented Nov 5, 2018 •
edited

Offline Data

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_v3/103X_dataRun2_v4

Offline Data Relval

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_dataRun2_relval_v6/103X_dataRun2_relval_v7

2018 MC realistic (updated ECAL conditions)

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_v7/103X_upgrade2018_realistic_v8
. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_HEfail_v3/103X_upgrade2018_realistic_HEfail_v4

2018 MC HI realistic conditions (added CastorGains_PbPb_v1.0_mc)

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018_realistic_HI_v7/103X_upgrade2018_realistic_HI_v8

Updated DECO 2018 Cosmic Queue (updated ECAL conditions)

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018cosmics_realistic_deco_v6/103X_upgrade2018cosmics_realistic_deco_v7

Added PEAK 2018 Cosmic Queue

. https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/103X_upgrade2018cosmics_realistic_deco_v7/103X_upgrade2018cosmics_realistic_peak_v1

@cmsbuild cmsbuild added this to the CMSSW_10_3_X milestone Nov 5, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018 •
edited

A new Pull Request was created by @lpernie (Luca Pernie) for CMSSW_10_3_X.

It involves the following packages:

Configuration/AlCa

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @mmusich, @tocheng this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@lpernie
Copy link
Contributor Author

lpernie commented Nov 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31484/console Started: 2018/11/05 23:11

@lpernie lpernie mentioned this pull request Nov 5, 2018
Merged
@lpernie
Copy link
Contributor Author

lpernie commented Nov 5, 2018

Backport of #25131

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

Pull request #25130 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 5, 2018

Pull request #25130 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 5, 2018

PR Link to #25108 (2018 HLT HIon menu V1.0)

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

+1
Tested at: b898e44
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25130/31484/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25130/31484/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11409 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3163099
  • DQMHistoTests: Total failures: 15242
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 3147641
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.684 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): 0.649 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 4.53 ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 1000.0 ): 0.051 KiB JetMET/SUSYDQM
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

boudoul
boudoul reviewed Nov 6, 2018
View reviewed changes
Configuration/AlCa/python/autoCond.py Outdated
'phase1_2018_cosmics' : '103X_upgrade2018cosmics_realistic_deco_v6',
'phase1_2018_cosmics' : '103X_upgrade2018cosmics_realistic_deco_v7',
# GlobalTag for MC production (cosmics) with realistic conditions for full Phase1 2018 detector, Strip tracker in PEAK mode
'phase1_2018_cosmics' : '103X_upgrade2018cosmics_realistic_peak_v1',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lpernie , I guess you meant phase1_2018_cosmics_peak for this one (otherwise you have a duplication in the dictionnary) Thanks

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[My comment can be also applied to other version (master etc..) of this PR ]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Correct, fixed now!

@fabiocos
Copy link
Contributor

fabiocos commented Nov 6, 2018

@lpernie @tocheng this PR seems to fully include #25069, am I correct?

@lpernie
Copy link
Contributor Author

lpernie commented Nov 6, 2018

@fabiocos yes you are correct

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 6, 2018

Pull request #25130 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Pull request #25130 was updated. @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please check and sign again.

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31562/console Started: 2018/11/09 17:17

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

+1
Tested at: ebffa8e
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25130/31562/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25130/31562/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11275 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3160863
  • DQMHistoTests: Total failures: 15069
  • DQMHistoTests: Total nulls: 19
  • DQMHistoTests: Total successes: 3145578
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.464 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 250202.181 ): 0.649 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 4.53 ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 158.0 ): -1.148 KiB L1T/L1TStage2uGT
  • DQMHistoSizes: changed ( 1000.0 ): 0.051 KiB JetMET/SUSYDQM
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor Author

lpernie commented Nov 9, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d88d72a into cms-sw:CMSSW_10_3_X Nov 14, 2018
@fabiocos fabiocos mentioned this pull request Nov 14, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boudoul boudoul boudoul left review comments

Assignees
No one assigned
Labels
alca-approved backport-ok comparison-available fully-signed orp-approved tests-approved
Projects
None yet
Milestone
CMSSW_10_3_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lpernie @cmsbuild @fabiocos @boudoul