Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving to 2018 Cosmic WFs and Re-adding 2016-2017 Cosmic WFs (10_2_X) #25152

Merged
merged 4 commits into from Nov 25, 2018

Conversation

boudoul
Copy link
Contributor

@boudoul boudoul commented Nov 7, 2018

Backport of #25137
Updating runthematrix cosmic WFs with the latest and greatest 2018 Cosmic GTs
The corresponding WFs are 7.2 , 7.3, 7.4

This PR is also backporting #25249 and #25276 to be fully in synch with 10_4 X (adding 2017-2016)
The corresponding WFs are 7.21 , 7.22
Thanks @lpernie for having provided the GTs

@mmusich @tsusa FYI

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

A new Pull Request was created by @boudoul (boudoul) for CMSSW_10_2_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

prebello commented Nov 7, 2018

please test workflow 7.2,7.3,7.4 with #25127

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31519/console Started: 2018/11/07 13:23

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25152/31519/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25152/7.2_Cosmics_UP18+Cosmics_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25152/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18
  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25152/7.4_Cosmics_UP18+Cosmics_UP18+DIGICOSPEAK_UP18+RECOCOSPEAK_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 11447 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2945096
  • DQMHistoTests: Total failures: 18690
  • DQMHistoTests: Total nulls: 20
  • DQMHistoTests: Total successes: 2926203
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 1.038 KiB( 29 files compared)
  • DQMHistoSizes: changed ( 1000.0 ): 0.051 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 4.53 ): -0.016 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 250202.181 ): 1.003 KiB SiStrip/MechanicalView
  • Checked 124 log files, 14 edm output root files, 31 DQM output files

@kpedro88
Copy link
Contributor

kpedro88 commented Nov 8, 2018

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented Nov 8, 2018

+1

@prebello
Copy link
Contributor

@boudoul thank you for your changes. Nevertheless, there is a typo. You have added 7.22 for both UP17 and UP16. Could you please fix it?

@cmsbuild
Copy link
Contributor

Pull request #25152 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@boudoul
Copy link
Contributor Author

boudoul commented Nov 23, 2018

Thanks @prebello for noticing !
fixed in my last commit

@kpedro88
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 23, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31827/console Started: 2018/11/23 18:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25152/31827/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 2945096
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2944909
  • DQMHistoTests: Total skipped: 183
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 29 files compared)
  • Checked 124 log files, 14 edm output root files, 31 DQM output files

@fabiocos
Copy link
Contributor

@prebello the PR looks ok to me to go, I would like to include it in next 10_2_X version I would like to build soon

@prebello
Copy link
Contributor

+1

sure @fabiocos go ahead

@fabiocos
Copy link
Contributor

+1

@kpedro88 although not specific for upgrade, please sign it for reference

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit bca2aa0 into cms-sw:CMSSW_10_2_X Nov 25, 2018
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants