Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module cleanup in DQM/L1TMonitor #25161

Merged
merged 1 commit into from Nov 10, 2018

Conversation

Dr15Jones
Copy link
Contributor

Made the following modifications in L1TRCT and L1TRPCTF

  • removed unused member variables
  • put globals into anonymous namespace to avoid poluting the global
    namespace
  • remove trivial member functions associated with Run and LuminosityBlock
    transitions.

Made the following modifications in L1TRCT and L1TRPCTF
- removed unused member variables
- put globals into anonymous namespace to avoid poluting the global
  namespace
- remove trivial member functions associated with Run and LuminosityBlock
  transitions.
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

DQM/L1TMonitor

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31538/console Started: 2018/11/08 17:43

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25161/31538/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25161/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013628
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

const unsigned int PHIBINS = 18;
const float PHIMIN = -0.5;
const float PHIMAX = 17.5;
namespace {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Dr15Jones for my understanding, what is the purpose of the definition of this unnamed namespace? Is it to ensure ot restrict the definition of the constants to the scope of this class (through this file as translation unit)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The anonymous namespace guarantees that all variables and classes defined within it do not have their symbols accessible outside the scope of the file. Without it, those variables are exported by the linker.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ac29e29 into cms-sw:master Nov 10, 2018
@Dr15Jones Dr15Jones deleted the cleanupDQM_L1TMonitor branch November 12, 2018 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants