New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Module cleanup in DQM/L1TMonitor #25161
Conversation
Made the following modifications in L1TRCT and L1TRPCTF - removed unused member variables - put globals into anonymous namespace to avoid poluting the global namespace - remove trivial member functions associated with Run and LuminosityBlock transitions.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25161/7160 |
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: DQM/L1TMonitor @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready @slava77 comparisons for the following workflows were not done due to missing matrix map:
Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
const unsigned int PHIBINS = 18; | ||
const float PHIMIN = -0.5; | ||
const float PHIMAX = 17.5; | ||
namespace { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Dr15Jones for my understanding, what is the purpose of the definition of this unnamed namespace? Is it to ensure ot restrict the definition of the constants to the scope of this class (through this file as translation unit)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The anonymous namespace guarantees that all variables and classes defined within it do not have their symbols accessible outside the scope of the file. Without it, those variables are exported by the linker.
+1 |
Made the following modifications in L1TRCT and L1TRPCTF
namespace
transitions.