Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate tracker local reconstruction and pixel tracking to Tasks #25163

Merged
merged 2 commits into from Nov 14, 2018

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Nov 8, 2018

Title says it all. This PR supersedes #25122 by including a "Task" somewhere in the added task names, and keeping the sequences for "backwards" compatibility (to avoid a massive migration as in #25110). I also included migration of pixel tracking configuration (I wanted to do that anyway, it is somewhat related, and doesn't add much changes).

Tested in CMSSW_10_4_X_2018-11-05-1100, no changes expected.

Keeping sequences to avoid massive migration (for now).
Keeping the sequences to avoid a massive migration (for now).
@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

RecoLocalTracker/Configuration
RecoPixelVertexing/Configuration
RecoPixelVertexing/PixelTrackFitting

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@echabert, @pieterdavid, @felicepantaleo, @forthommel, @yduhm, @GiacomoSguazzoni, @gbenelli, @rovere, @VinInn, @alesaggio, @threus, @gpetruc, @ebrondol, @mmusich, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Nov 8, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31544/console Started: 2018/11/08 21:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 8, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 9, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25163/31544/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25163/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013827
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013629
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@slava77
Copy link
Contributor

slava77 commented Nov 13, 2018

+1

for #25163 5cea7c0

  • technical configuration code changes are in line with the PR description
  • jenkins tests pass and comparisons with the baseline show no (relevant) differences

fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 19, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 20, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Oct 23, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 6, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 16, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Nov 27, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Dec 25, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Dec 26, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 26, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Dec 29, 2020
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard pushed a commit to cms-patatrack/cmssw that referenced this pull request Jan 13, 2021
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Jan 15, 2021
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Jan 15, 2021
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Mar 23, 2021
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
fwyzard added a commit to cms-patatrack/cmssw that referenced this pull request Apr 1, 2021
…kport cms-sw#25163) (#202)

Backport "Migrate tracker local reconstruction and pixel tracking to Tasks" (cms-sw#25163) to the Patatrack branch:
  - migrate RecoLocalTracker_cff to Tasks;
  - migrate RecoPixelVertexing_cff to Tasks;
  - keeping sequences to avoid massive migration (for now).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants