Raising clusterChecker threshhold slightly for Heavy Ion collisions

[abaty]

We have found that the default parameter 'maxNumberOfCosmicClusters' is causing a few very central heavy ion collisions to bail on the tracking, although these events appear to be good physics events. We would like to raise this threshhold from 400k to 500k to prevent any bias to physics. More information on the investigation of these very large events that the tracking is bailing on is given here:

https://www.dropbox.com/s/pgfp21e2329ly69/MonsterEventInvestigation_Nov10.pdf?dl=0

Two of these events, which normally have the tracking not run, as well as a RECO config for testing can be found here:

/afs/cern.ch/user/a/abaty/public/forClusterCheckPR

A backport PR for 10_3_1 will follow shortly.

@mandrenguyen @icali @echapon @mverwe

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25189/7190

[cmsbuild]

A new Pull Request was created by @abaty for master.

It involves the following packages:

RecoTracker/TkSeedGenerator

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @felicepantaleo, @GiacomoSguazzoni, @rovere, @VinInn, @mschrode, @gpetruc, @ebrondol, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31577/console Started: 2018/11/10 15:18

[slava77]

I looked at the slides and this appears to be a somewhat straightforward "+1"

[cmsbuild]

+1
Tested at: 28890f5
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25189/31577/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25189/31577/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25189/7.3_CosmicsSPLoose_UP18+CosmicsSPLoose_UP18+DIGICOS_UP18+RECOCOS_UP18+ALCACOS_UP18+HARVESTCOS_UP18

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013827
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013629
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[slava77]

+1

for #25189 28890f5

• code changes are in line with the PR description.
• jenkins tests pass and comparisons with the baseline show no differences (only very high occupancy events in pp_on_AA processing for HI can be affected; they are not in the standard tests).

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

+1