Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2018 HLT HIon menu V1.4 #25216

Merged
merged 14 commits into from Nov 16, 2018
Merged

Conversation

Martin-Grunewald
Copy link
Contributor

2018 HLT HIon menu V1.4
Based on CMSSW_10_3_0_pre6

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_10_3_X.

It involves the following packages:

Configuration/HLT
HLTrigger/Configuration
Utilities/ReleaseScripts

@Martin-Grunewald, @smuzaffar, @cmsbuild, @Dr15Jones, @fwyzard can you please review it and eventually sign? Thanks.
@makortel, @geoff-smith, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Martin-Grunewald
Copy link
Contributor Author

backport of #25215

@Martin-Grunewald
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31616/console Started: 2018/11/13 08:35

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25216/31616/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3162899
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3162700
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@Martin-Grunewald
Copy link
Contributor Author

+1

@Dr15Jones
Copy link
Contributor

+1
for addOnTests.py

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@Martin-Grunewald this is the CMSSW version of the menu currently used in data taking, am I correct?

@Martin-Grunewald
Copy link
Contributor Author

Yes, this is the HLT menu currently running online.

@Martin-Grunewald
Copy link
Contributor Author

@fabiocos
So which one is to be integrated? Eventually of course V1.4.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 1b1ba96 into cms-sw:CMSSW_10_3_X Nov 16, 2018
@fabiocos
Copy link
Contributor

@Martin-Grunewald as this is already in production, and there was no obvious problem after its integration in master, let's move forward with this

@Martin-Grunewald Martin-Grunewald deleted the V1p4HLT103XHIon branch November 17, 2018 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants