Move MTD geometry test from expanded to filtered view #25217

fabiocos · 2018-11-13T09:39:03Z

This PR addresses a comment of @ianna about using only filtered views for geometry navigation.
As in the case of these tests the whole geometry tree structure is scanned, a pass through filter is used.

cmsbuild · 2018-11-13T09:39:22Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-13T09:40:47Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25217/7229

cmsbuild · 2018-11-13T09:41:07Z

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Geometry/MTDCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

fabiocos · 2018-11-13T09:42:54Z

please test

not testing anything, the test modules have been probed with the standalone configuration provided in the Geometry/MTDCommonData package

cmsbuild · 2018-11-13T09:43:12Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31621/console Started: 2018/11/13 10:43

fabiocos · 2018-11-13T09:44:27Z

@ianna please let me know whether this is what you had in mind, in this case I do not see a specific attribute to select without changing the logic of the code

ianna · 2018-11-13T09:46:28Z

Geometry/MTDCommonData/test/TestMTDNumbering.cc

@@ -17,9 +17,9 @@
 #include "Geometry/Records/interface/IdealGeometryRecord.h"

 #include "DetectorDescription/Core/interface/DDValue.h"
-#include "DetectorDescription/Core/interface/DDCompactView.h"
 #include "DetectorDescription/Core/interface/DDExpandedNode.h"


@fabiocos - is it needed?

ianna · 2018-11-13T09:47:14Z

Geometry/MTDCommonData/test/TestMTDNumbering.cc

+
+  edm::LogInfo("TestMTDNumbering") << "Top Most LogicalPart = " << fv.logicalPart();
+
+  typedef DDFilteredView::nav_type nav_type;


using nav_type = DDFilteredView::nav_type;

ianna · 2018-11-13T09:47:51Z

Geometry/MTDCommonData/test/TestMTDNumbering.cc

+
+  edm::LogInfo("TestMTDNumbering") << "Top Most LogicalPart = " << fv.logicalPart();
+
+  typedef DDFilteredView::nav_type nav_type;
  typedef std::map<nav_type,int> id_type;


using id_type = std::map<nav_type,int>;

ianna · 2018-11-13T09:48:36Z

Geometry/MTDCommonData/test/TestMTDPosition.cc

@@ -18,9 +18,9 @@
 #include "Geometry/Records/interface/IdealGeometryRecord.h"

 #include "DetectorDescription/Core/interface/DDValue.h"
-#include "DetectorDescription/Core/interface/DDCompactView.h"
 #include "DetectorDescription/Core/interface/DDExpandedNode.h"


is it needed?

cmsbuild · 2018-11-13T11:43:57Z

+1
Tested at: 025c9c2
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25217/31621/summary.html

cmsbuild · 2018-11-13T11:43:59Z

Comparison job queued.

cmsbuild · 2018-11-13T13:35:17Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25217/31621/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25217/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3013311
DQMHistoTests: Total failures: 11
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3013103
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

cmsbuild · 2018-11-13T15:58:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-13T15:59:10Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25217/7234

cmsbuild · 2018-11-13T15:59:37Z

Pull request #25217 was updated. @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please check and sign again.

ianna · 2018-11-13T16:12:41Z

+1

cmsbuild · 2018-11-13T16:13:00Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31630/console Started: 2018/11/13 17:13

cmsbuild · 2018-11-13T18:37:23Z

+1
Tested at: 5c8bc2a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25217/31630/summary.html

cmsbuild · 2018-11-13T18:37:26Z

Comparison job queued.

cmsbuild · 2018-11-13T20:27:16Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25217/31630/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

/build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25217/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3013311
DQMHistoTests: Total failures: 19
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3013095
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 134 log files, 14 edm output root files, 32 DQM output files

fabiocos · 2018-11-14T06:46:26Z

@kpedro88 this is the code cleaning and move to filtered view of two standalone test classes not used in any production workflow

kpedro88 · 2018-11-14T15:04:37Z

+upgrade

cmsbuild · 2018-11-14T15:04:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-11-15T08:52:18Z

+1

Move MTD geometry test from expanded to filtered view

025c9c2

cmsbuild added this to the CMSSW_10_4_X milestone Nov 13, 2018

cmsbuild added code-checks-pending comparison-pending geometry-pending orp-pending pending-signatures tests-pending upgrade-pending labels Nov 13, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 13, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 13, 2018

ianna suggested changes Nov 13, 2018

View reviewed changes

cmsbuild added tests-approved and removed tests-started labels Nov 13, 2018

cmsbuild added comparison-available and removed comparison-pending labels Nov 13, 2018

code cleaning according to Yana's comments

5c8bc2a

cmsbuild removed code-checks-approved comparison-available labels Nov 13, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 13, 2018

cmsbuild added geometry-approved and removed geometry-pending labels Nov 13, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 13, 2018

cmsbuild added tests-approved and removed tests-started labels Nov 13, 2018

cmsbuild added comparison-available and removed comparison-pending labels Nov 13, 2018

cmsbuild added fully-signed upgrade-approved and removed pending-signatures upgrade-pending labels Nov 14, 2018

cmsbuild added orp-approved and removed orp-pending labels Nov 15, 2018

cmsbuild merged commit fe1b8c3 into cms-sw:master Nov 15, 2018

fabiocos deleted the fc-updateDDtest branch November 16, 2018 16:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Move MTD geometry test from expanded to filtered view #25217

Move MTD geometry test from expanded to filtered view #25217

fabiocos commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

fabiocos commented Nov 13, 2018

cmsbuild commented Nov 13, 2018 •

edited

fabiocos commented Nov 13, 2018

ianna Nov 13, 2018

ianna Nov 13, 2018

ianna Nov 13, 2018

ianna Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

ianna commented Nov 13, 2018

cmsbuild commented Nov 13, 2018 •

edited

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

fabiocos commented Nov 14, 2018

kpedro88 commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

fabiocos commented Nov 15, 2018


		edm::LogInfo("TestMTDNumbering") << "Top Most LogicalPart = " << fv.logicalPart();

		typedef DDFilteredView::nav_type nav_type;

Move MTD geometry test from expanded to filtered view #25217

Move MTD geometry test from expanded to filtered view #25217

Conversation

fabiocos commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

fabiocos commented Nov 13, 2018

cmsbuild commented Nov 13, 2018 • edited

fabiocos commented Nov 13, 2018

ianna Nov 13, 2018

Choose a reason for hiding this comment

ianna Nov 13, 2018

Choose a reason for hiding this comment

ianna Nov 13, 2018

Choose a reason for hiding this comment

ianna Nov 13, 2018

Choose a reason for hiding this comment

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

ianna commented Nov 13, 2018

cmsbuild commented Nov 13, 2018 • edited

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

cmsbuild commented Nov 13, 2018

fabiocos commented Nov 14, 2018

kpedro88 commented Nov 14, 2018

cmsbuild commented Nov 14, 2018

fabiocos commented Nov 15, 2018

cmsbuild commented Nov 13, 2018 •

edited

cmsbuild commented Nov 13, 2018 •

edited