Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update of the Zmumu validation tool, pull request to master branch #25220

Merged
merged 1 commit into from Nov 21, 2018

Conversation

cardinia
Copy link
Contributor

This pull request was originally made to a wrong branch by mistake (#25159). The current version takes into account the comments and suggestions received in the discussion regarding the previous pull request.

Description:
@connorpa @adewit
Implemented features:
2D plots Mass vs EtaPhi of muon (plus or minus)
Plotting options regarding the Y axis range in 1D histograms

Features presented in:
https://indico.cern.ch/event/768246/#72-latest-developments-of-vali
https://indico.cern.ch/event/688851/#sc-28-2-improvement-of-z-valid

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @cardinia for master.

It involves the following packages:

Alignment/OfflineValidation
MuonAnalysis/MomentumScaleCalibration

@tocheng, @monttj, @cmsbuild, @franzoni, @fgolf, @pohsun, @peruzzim, @lpernie can you please review it and eventually sign? Thanks.
@adewit, @tocheng, @argiro, @bellan, @tlampen, @mschrode, @mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@pohsun
Copy link

pohsun commented Nov 13, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31636/console Started: 2018/11/13 18:15

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25220/31636/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25220/27434.0_TTbar_14TeV+TTbar_14TeV_TuneCUETP8M1_2023D35_GenSimHLBeamSpotFull14+DigiFullTrigger_2023D35+RecoFullGlobal_2023D35+HARVESTFullGlobal_2023D35

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 19
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013095
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@lpernie
Copy link
Contributor

lpernie commented Nov 20, 2018

+1

@fabiocos
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 4d5eced into cms-sw:master Nov 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants