New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some beta-star variables for JEC workflows. Intended for NANOAOD. Backport of #25223 to 9.4.x #25225
Adding some beta-star variables for JEC workflows. Intended for NANOAOD. Backport of #25223 to 9.4.x #25225
Conversation
A new Pull Request was created by @rappoccio for CMSSW_9_4_X. It involves the following packages: RecoJets/JetProducers @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
backport of #25223 |
The implementation of BetaStarVarProducer.cc contains here many more (mostly useless) comments with respect to the one merged in the master with #25223. Please, let have the very same code implemented in the master and in these backports (ideally you could have cherry-picked the very same commit: now you could probably more easily copy the same file which is in the master and commit it): this would also facilitate the backports of possible future fixes. |
please test |
The tests are being triggered in jenkins. |
+1 The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic: |
Comparison job queued. |
the large list of extra merge commits is suggestive of a wrong branch used for developing this PR, |
Indeed: "Merge CMSSW_9_4_X into CMSSW_9_4_AN_X" |
So what is the right branch? CMSSW_9_4_AN_X? |
You are submitting to 9_4_X, and therefore you must use that branch for your PR |
60bde88
to
ff4b1e0
Compare
OK should be good now. |
Comparison is ready Comparison Summary:
|
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
code-checks |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25225/8516
|
+1 |
This adds some value maps that are not currently used in any production. They compute the beta-star variables used by the L1 jet correction team. This is intended for NANOAOD (either standard, or the upcoming JME workflow).