Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding some beta-star variables for JEC workflows. Intended for NANOAOD. Backport of #25223 to 9.4.x #25225

Merged
merged 1 commit into from Feb 22, 2019

Conversation

rappoccio
Copy link
Contributor

This adds some value maps that are not currently used in any production. They compute the beta-star variables used by the L1 jet correction team. This is intended for NANOAOD (either standard, or the upcoming JME workflow).

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 13, 2018

A new Pull Request was created by @rappoccio for CMSSW_9_4_X.

It involves the following packages:

RecoJets/JetProducers

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @jdolen, @ahinzmann, @jdamgov, @yslai, @nhanvtran, @gkasieczka, @clelange, @schoef, @mariadalfonso, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@perrotta
Copy link
Contributor

backport of #25223

@perrotta
Copy link
Contributor

The implementation of BetaStarVarProducer.cc contains here many more (mostly useless) comments with respect to the one merged in the master with #25223. Please, let have the very same code implemented in the master and in these backports (ideally you could have cherry-picked the very same commit: now you could probably more easily copy the same file which is in the master and commit it): this would also facilitate the backports of possible future fixes.

@cmsbuild
Copy link
Contributor

Pull request #25225 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31854/console Started: 2018/11/26 16:28

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Nov 26, 2018

the large list of extra merge commits is suggestive of a wrong branch used for developing this PR,

@perrotta
Copy link
Contributor

Indeed: "Merge CMSSW_9_4_X into CMSSW_9_4_AN_X"

@rappoccio
Copy link
Contributor Author

So what is the right branch? CMSSW_9_4_AN_X?

@perrotta
Copy link
Contributor

You are submitting to 9_4_X, and therefore you must use that branch for your PR

@cmsbuild
Copy link
Contributor

Pull request #25225 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@rappoccio
Copy link
Contributor Author

OK should be good now.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25225/31854/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 112
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721219
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31863/console Started: 2018/11/26 21:54

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25225/31863/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 105
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721226
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@perrotta
Copy link
Contributor

+1

  • The inclusion of the module as in this PR does not affect the standard sequences and workflows
  • Jenkins tests pass
  • Validation of the content of the produced objects is left to the nanoAOD developers from the JetMET POG

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25225/8516

  • This PR adds an extra 12KB to repository

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit a42ac48 into cms-sw:CMSSW_9_4_X Feb 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants