Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wf 140.56 to the short matrix as requested by RECO #25266

Merged
merged 2 commits into from Nov 21, 2018

Conversation

fabiocos
Copy link
Contributor

Addressing the discussion in #25210 (comment)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@fabiocos fabiocos changed the title Add wf 140.56 to the short matrix as requested by Slava Add wf 140.56 to the short matrix as requested by RECO Nov 16, 2018
@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@prebello
Copy link
Contributor

please test workflow 140.56 with #25210

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 16, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31701/console Started: 2018/11/16 18:28

@fabiocos
Copy link
Contributor Author

let's take note of #25210 (review)

@cmsbuild
Copy link
Contributor

Comparison job queued.

@slava77
Copy link
Contributor

slava77 commented Nov 16, 2018

140.56 here took only 90 mins (from ~19:30 to 21:00).
If I parsed the build info correctly, this was on cmsbuild02.
I guess this machine is almost a factor of 2 faster than mine.
@smuzaffar what type of hardware is this. Do you know?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25266/31701/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 1076 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 130
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3012984
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

@slava77 @smuzaffar on cmsdev15 in single threaded mode I get

TimeReport> Time report complete in 5001.44 seconds
Time Summary:

  • Min event: 7.24736
  • Max event: 345.884
  • Avg event: 162.316
  • Total loop: 4917.85
  • Total init: 61.1077
  • Total job: 5001.44
  • EventSetup Lock: 0.000586987
  • EventSetup Get: 44.8936
    Event Throughput: 0.00610023 ev/s
    CPU Summary:
  • Total loop: 4908.42
  • Total init: 65.3921
  • Total extra: 0
  • Total job: 4994.66
    Processing Summary:
  • Number of Events: 30
  • Number of Global Begin Lumi Calls: 1
  • Number of Global Begin Run Calls: 1

Begin processing the 1st record. Run 326479, Event 1394020, LumiSection 7 on stream 0 at 16-Nov-2018 19:51:38.832 CET
Begin processing the 30th record. Run 326479, Event 1517636, LumiSection 7 on stream 0 at 16-Nov-2018 21:09:31.770 CET

this should be enough not to give TimeOut problems, the point is how well this is representative of the typical node used @smuzaffar

@smuzaffar
Copy link
Contributor

@fabiocos , @slava77 , most of our build machines are 8 Core (15GB) virtual machines.
Note that job was reading data from outside CERN, this could be the cause of slowness

6-Nov-2018 19:28:06 CET  Initiating request to open file root://eoscms.cern.ch//eos/cms/store/user/cmsbuild/store/hidata/HIRun2018A/HIHardProbes/RAW/v1/000/326/479/00000/0E2CC5D5-9D87-7348-9219-B00CD718C847.root
%MSG-w XrdAdaptorInternal:  file_open 16-Nov-2018 19:28:07 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/hidata/HIRun2018A/HIHardProbes/RAW/v1/000/326/479/00000/0E2CC5D5-9D87-7348-9219-B00CD718C847.root.
%MSG
%MSG-w XrdAdaptorInternal:  file_open 16-Nov-2018 19:28:08 CET pre-events
Failed to open file at URL root://eoscms.cern.ch:1094//eos/cms/store/user/cmsbuild/store/hidata/HIRun2018A/HIHardProbes/RAW/v1/000/326/479/00000/0E2CC5D5-9D87-7348-9219-B00CD718C847.root?tried=.
%MSG
16-Nov-2018 19:28:08 CET  Fallback request to file root://cms-xrd-global.cern.ch//store/hidata/HIRun2018A/HIHardProbes/RAW/v1/000/326/479/00000/0E2CC5D5-9D87-7348-9219-B00CD718C847.root
%MSG-w XrdAdaptor:  file_open 16-Nov-2018 19:28:10 CET pre-events
Data is served from cern.ch instead of original site T2_CH_CERN
%MSG
16-Nov-2018 19:28:10 CET  Successfully opened file root://cms-xrd-global.cern.ch//store/hidata/HIRun2018A/HIHardProbes/RAW/v1/000/326/479/00000/0E2CC5D5-9D87-7348-9219-B00CD718C847.root
%MSG-w GeometryGlobalTrackingGeometryBuilder:   DTChamberEfficiency:dtEfficiencyMonitor@beginRun 16-Nov-2018 19:29:17 CET  Run: 326479
No MTDDigiGeometryRecord is available.

@cmsbuild
Copy link
Contributor

Pull request #25266 was updated. @pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please check and sign again.

@fabiocos
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 20, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31768/console Started: 2018/11/20 18:55

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25266/31768/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013111
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

In the test the wf 140.56 was executed in about 40 minutes, roughly as 136.85. I would say we can move forward and keep an eye on possible issues at this point (in a couple of weeks this test might be no more so useful)

@prebello
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor Author

@kpedro88 this is not specific for upgrade, please sign it for reference in case

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit 9c10af4 into cms-sw:master Nov 21, 2018
@kpedro88
Copy link
Contributor

+upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will be automatically merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants