Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an override version option for standard PyReleaseValidation workflows (Backport PR 25245) #25273

Merged
merged 1 commit into from Nov 18, 2018

Conversation

fabiocos
Copy link
Contributor

This PR addresses the problem discussed in #24850, that is causing wf 250204.18 to be broken since more than on month. The version of the input RelVal to be used is not the default one, but the override mechanism added for the upgrade version is not directly applicable to the standard relval workflows because they are added with a different syntax.

Here the dataset stored in the desired element of the dictionary is extracted, modified according to the predefined input dictionary "overrideFragment", and the dictionary element is re-created with the new definition.

Verified to solve the pending issue when running the command runTheMatrix.py -i all -t 4 -l 250204.18. Note: the sample is not present at CERN but existent (FNAL), so it will be copied.

backport #25245

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for CMSSW_10_3_X.

It involves the following packages:

Configuration/PyReleaseValidation

@pgunnell, @zhenhu, @prebello, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test workflow 250204.18

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31716/console Started: 2018/11/18 11:02

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25273/31716/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25273/250204.18_QQH1352T_13UP18+QQH1352T_13UP18+DIGIPRMXUP18_PU25+RECOPRMXUP18_PU25+HARVESTUP18_PU25

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3160863
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3160664
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@fabiocos
Copy link
Contributor Author

@prebello @zhenhu @kpedro88 this is the backport of the fix you have already signed in 10_4_X, I will move forward with the merge to clean the 10_3_X IB, please sign it for reference

@fabiocos
Copy link
Contributor Author

+1

@fabiocos
Copy link
Contributor Author

merge

@cmsbuild cmsbuild merged commit b414296 into cms-sw:CMSSW_10_3_X Nov 18, 2018
@kpedro88
Copy link
Contributor

backport of #25245

@kpedro88
Copy link
Contributor

+upgrade

@zhenhu
Copy link
Contributor

zhenhu commented Nov 18, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will be automatically merged.

@fabiocos fabiocos deleted the fc-back25245 branch November 19, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants