Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L1TCalo: Add new caloParams with updated HI centrality v1_4_1 #25279

Merged
merged 2 commits into from Nov 27, 2018

Conversation

bundocka
Copy link
Contributor

New centrality tuning.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bundocka for master.

It involves the following packages:

L1Trigger/Configuration
L1Trigger/L1TCalorimeter

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@thomreis
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 19, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31736/console Started: 2018/11/19 17:25

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25279/31736/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3013311
  • DQMHistoTests: Total failures: 101
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3013013
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 134 log files, 14 edm output root files, 32 DQM output files

@thomreis
Copy link
Contributor

Hi @bundocka
are these changes tested with the standard WFs? Are the failing comparisons expected or unrelated?

@bundocka
Copy link
Contributor Author

I've just added a new offline config with updated HI parameters. Nothing in the standard WFs should be affected.

@thomreis
Copy link
Contributor

Those configs have been tested locally then?

@bundocka
Copy link
Contributor Author

Yes, I didn't see any problems

@thomreis
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@bundocka bundocka changed the title Add new caloParams with updated HI centrality v1_4_1 L1TCalo: Add new caloParams with updated HI centrality v1_4_1 Nov 20, 2018
@fabiocos
Copy link
Contributor

@bundocka @thomreis for my understanding, where is this new customise used? In the release out of the box nowhere I would say...

@fabiocos
Copy link
Contributor

@bundocka @thomreis could you please clarify? I assume this is needed in production

@fabiocos
Copy link
Contributor

@rekovic @bundocka @thomreis could you please clarify? I assume this is needed in production

@bundocka
Copy link
Contributor Author

Hi,
This customisation isn't used in any central workflows, but provides the latest HI centrality classes that are used online. This would only be used to configure the emulator manually.

@fabiocos
Copy link
Contributor

@bundocka ok thanks

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit b6b485d into cms-sw:master Nov 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants