DD4hep: Update Units Check Script

[ianna]

• Update print to Python3
• Align error marker when there are tabs used in a line

[ianna]

please test

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25281/7300

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31732/console Started: 2018/11/19 16:10

[cmsbuild]

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: 7f60479
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25281/31732/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25281/31732/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3013311
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3013111
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 134 log files, 14 edm output root files, 32 DQM output files

[cvuosalo]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@ianna I see that you have protected the script against reports for MaterialFraction. There are anyway other cases that could be considered. Running the script in the form proposed in this PR:

/build/fabiocos/104X/25281/CMSSW_10_4_X_2018-11-19-2300/src/DetectorDescription/DDCMS/data/materials.xml: line# 4 warning: numerical value without units:
ElementaryMaterial name="Aluminium" density="2.7g/cm3" symbol=" " atomicWeight="26.98g/mole" atomicNumber="13"

atomicNumber is a pure number

/build/fabiocos/104X/25281/CMSSW_10_4_X_2018-11-19-2300/src/DetectorDescription/DDCMS/data/materials.xml: line# 336 warning: numerical value without units:
CompositeMaterial name="Aluminium 2219" density="2.84*g/cm3" symbol=" " method="mixture by weight"

Aluminium 2219 is just the material name

It depends on how stringent you want to do the test, as you may have multiple instances of numerical values in the same line, and the logic in the check does not easily disentangle them I am afraid, do you agree?``

[ianna]

@fabiocos - yes, I'm not sure how far we want to go with the script.

[fabiocos]

+1