Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for phase1 geometry of phase0 misalignment scenarios #25350

Conversation

consuegs
Copy link
Contributor

@consuegs consuegs commented Nov 26, 2018

Update for phase1 geometry of phase0 misalignment scenarios. Main change: object Ids.

Previous file Scenarios_cff.py, containing phase0 geometry scenarios will contain now phase1 geometry scenarios and Scenarios_phase0_cff.py will store phase0 geometry scenarios for documentation purposes

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @consuegs for master.

It involves the following packages:

Alignment/TrackerAlignment

@cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks.
@mschrode, @mmusich, @adewit, @tocheng, @tlampen this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@tocheng
Copy link
Contributor

tocheng commented Nov 26, 2018

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 26, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31868/console Started: 2018/11/27 00:28

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25350/31868/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@boudoul
Copy link
Contributor

boudoul commented Nov 27, 2018

Hello @consuegs , Just for me to understand - You mentionned in the description that you keep phase0 for documentation , I guess this is more than for documention, are you not going to use this for the Ultra Legacy work when adressing the 2016 period (phase0) ?

@mmusich
Copy link
Contributor

mmusich commented Nov 27, 2018

Hello @consuegs , Just for me to understand - You mentionned in the description that you keep phase0 for documentation , I guess this is more than for documention, are you not going to use this for the Ultra Legacy work when adressing the 2016 period (phase0) ?

Hi @boudoul, allow me to chime in.
While it is certainly true that the phase0 scenarios might still be used to create a step-0 misalignment for the phase-0 geometry in the context of the ultra-legacy, the purpose of this PR is mainly to document the phase-I scenarios that the alignment group has prepared to allow POGs to perform systematic misalignment studies. As you see the phase-0 file is untouched (only renamed) and remains available in case of need.
cc @hroskes @connorpa

@consuegs
Copy link
Contributor Author

Hello @consuegs , Just for me to understand - You mentionned in the description that you keep phase0 for documentation , I guess this is more than for documention, are you not going to use this for the Ultra Legacy work when adressing the 2016 period (phase0) ?

Hi @boudoul, as explained by @mmusich, I meant for documentation purposes, in the sense of upcoming work (not related to campaigns as the ultra-legacy effort) in which we will definitely need an up to date file for the creation of misalignment scenarios

@boudoul
Copy link
Contributor

boudoul commented Nov 27, 2018

Thanks @consuegs and @mmusich for the clarifications !

@pohsun
Copy link

pohsun commented Dec 12, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@consuegs @mmusich besides the PR test, what is the expected effect of this? Am I correct that it does not affect directly production workflows, but just the preparation of alignment to be stored in the DB?

@mmusich
Copy link
Contributor

mmusich commented Dec 16, 2018

@fabiocos, your interpretation is correct.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c1a6e88 into cms-sw:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants