New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for phase1 geometry of phase0 misalignment scenarios #25350
Update for phase1 geometry of phase0 misalignment scenarios #25350
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25350/7373 |
A new Pull Request was created by @consuegs for master. It involves the following packages: Alignment/TrackerAlignment @cmsbuild, @franzoni, @pohsun, @tocheng, @lpernie can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
Hello @consuegs , Just for me to understand - You mentionned in the description that you keep phase0 for documentation , I guess this is more than for documention, are you not going to use this for the Ultra Legacy work when adressing the 2016 period (phase0) ? |
Hi @boudoul, allow me to chime in. |
Hi @boudoul, as explained by @mmusich, I meant for documentation purposes, in the sense of upcoming work (not related to campaigns as the ultra-legacy effort) in which we will definitely need an up to date file for the creation of misalignment scenarios |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@fabiocos, your interpretation is correct. |
+1 |
Update for phase1 geometry of phase0 misalignment scenarios. Main change: object Ids.
Previous file Scenarios_cff.py, containing phase0 geometry scenarios will contain now phase1 geometry scenarios and Scenarios_phase0_cff.py will store phase0 geometry scenarios for documentation purposes