Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HCALDQM: Move channel quality lookup to dqmBeginLuminosityBlock (+increase pedestal RMS axis) #25360

Merged
merged 3 commits into from Dec 6, 2018

Conversation

DryRun
Copy link
Contributor

@DryRun DryRun commented Nov 28, 2018

This PR accompanies #25351, which implements LS-level granularity in HcalChannelQuality conditions. For HCAL DQM, this means that the HcalChannelQuality retrieval should happen in dqmBeginLuminosityBlock, rather than beginRun.

I also include a small fix for the ADC axis on pedestal RMS plots, which was too small by the end of the year.

@abdoulline
Copy link

@smuzaffar
looks like something went wrong with the PR processing initialization?

@smuzaffar
Copy link
Contributor

cmsbot ping

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@abdoulline
Copy link

@smuzaffar Thanks

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @DryRun (David Yu) for master.

It involves the following packages:

DQM/HcalCommon
DQM/HcalTasks

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@deguio this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Nov 29, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31907/console Started: 2018/11/29 12:38

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25360/31907/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131634
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Pull request #25360 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32011/console Started: 2018/12/05 16:04

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25360/32011/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131939
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131733
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 6, 2018

+1

@cmsbuild cmsbuild merged commit 6c74072 into cms-sw:master Dec 6, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
HCALDQM: Move channel quality lookup to dqmBeginLuminosityBlock (+increase pedestal RMS axis)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants