New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HCALDQM: Move channel quality lookup to dqmBeginLuminosityBlock (+increase pedestal RMS axis) #25360
Conversation
@smuzaffar |
cmsbot ping |
The code-checks are being triggered in jenkins. |
@smuzaffar Thanks |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25360/7403 |
A new Pull Request was created by @DryRun (David Yu) for master. It involves the following packages: DQM/HcalCommon @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25360/7475 |
Pull request #25360 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again. |
+1 |
The tests are being triggered in jenkins. |
This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
HCALDQM: Move channel quality lookup to dqmBeginLuminosityBlock (+increase pedestal RMS axis)
This PR accompanies #25351, which implements LS-level granularity in HcalChannelQuality conditions. For HCAL DQM, this means that the HcalChannelQuality retrieval should happen in dqmBeginLuminosityBlock, rather than beginRun.
I also include a small fix for the ADC axis on pedestal RMS plots, which was too small by the end of the year.