Return unique_ptr from fetchPayload

[wddgit]

These changes logically follow the changes in PR #25126 and are one level higher in the stack. Please see the comments to that PR which apply to this PR also except that the function modified is fetchPayload instead of deserialize. There will be one more pull request after this one that changes many of the ESProducers that depend on the fetchPayload function.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25364/7401

[cmsbuild]

A new Pull Request was created by @wddgit (W. David Dagenhart) for master.

It involves the following packages:

CondCore/CondDB

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[wddgit]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31903/console Started: 2018/11/28 22:12

[cmsbuild]

+1
Tested at: a2a0b57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25364/31903/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25364/31903/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3131839
• DQMHistoTests: Total failures: 100
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3131535
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[ggovi]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

@ggovi changes in DQM look unrelated to this PR, and mostly referring to L1T in its not properly reproducible part, could you please confirm?

[fabiocos]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32048/console Started: 2018/12/07 11:10

[ggovi]

@fabiocos
I can't imagine how the changes here could affect DQM . It should be totally unrelated.

[cmsbuild]

+1
Tested at: a2a0b57
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25364/32048/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25364/32048/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3136422
• DQMHistoTests: Total failures: 99
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3136119
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[fabiocos]

recompiling this file triggers the recompilation of a long list of packages, among them L1Trigger/L1TCalorimeter where L1TCaloStage2ParamsESProducer is present. This could explain why the L1TEMU plots for this sector show non-reproducibility, know but still not cured

@rekovic @thomreis is there any activity on this? The problem is now lasting since Summer...

[fabiocos]

+1