fix TrackTimeValueProducer inputs for premixing #25383

kpedro88 · 2018-11-30T00:04:13Z

@jingyucms found a crash in WF 27634.99 step4:

----- Begin Fatal Exception 29-Nov-2018 11:33:58 CST-----------------------
An exception of category 'InvalidReference' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step6'
   [2] Prefetching for module CaloParticleValidation/'caloparticlevalidation'
   [3] Prefetching for module SimPFProducer/'simPFProducer'
   [4] Calling method for module TrackTimeValueMapProducer/'trackTimeValueMapProducer'
Exception Message:
ClusterTPAssociation has TrackingParticles with ProductID 2:158, but got TrackingParticleRef/Handle/ProductID with ID 2:157. This is typically caused by a configuration error.
----- End Fatal Exception -------------------------------------------------

This PR fixes the problem. attn: @makortel

kpedro88 · 2018-11-30T00:04:33Z

please test

cmsbuild · 2018-11-30T00:04:33Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-30T00:06:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25383/7417

cmsbuild · 2018-11-30T00:06:37Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31916/console Started: 2018/11/30 01:07

cmsbuild · 2018-11-30T00:06:39Z

A new Pull Request was created by @kpedro88 (Kevin Pedro) for master.

It involves the following packages:

SimTracker/TrackAssociation

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @rovere, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2018-11-30T02:26:25Z

+1
Tested at: 7bc57b7
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25383/31916/summary.html

cmsbuild · 2018-11-30T02:26:28Z

Comparison job queued.

cmsbuild · 2018-11-30T04:09:50Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25383/31916/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131839
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131634
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

makortel · 2018-11-30T14:48:06Z

SimTracker/TrackAssociation/python/trackTimeValueMapProducer_cfi.py

+from Configuration.ProcessModifiers.premix_stage2_cff import premix_stage2
+premix_stage2.toModify(trackTimeValueMapProducer,
+    trackingParticleSrc = cms.InputTag("mixData:MergedTrackTruth"),
+    trackingVertexSrc = cms.InputTag("mixData:MergedTrackTruth"),


Could you remove the explicit types from the right-hand side?

cmsbuild · 2018-11-30T14:50:19Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-11-30T14:53:34Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25383/7421

kpedro88 · 2018-11-30T14:53:46Z

please test

cmsbuild · 2018-11-30T14:53:53Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31922/console Started: 2018/11/30 15:54

cmsbuild · 2018-11-30T14:53:55Z

Pull request #25383 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

cmsbuild · 2018-11-30T17:10:23Z

+1
Tested at: b424bc4
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25383/31922/summary.html

cmsbuild · 2018-11-30T17:10:27Z

Comparison job queued.

cmsbuild · 2018-11-30T18:49:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25383/31922/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 3 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131839
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131634
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

civanch · 2018-12-02T20:46:40Z

+1

cmsbuild · 2018-12-02T20:47:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-12-03T08:42:03Z

+1

fix inputs for premixing

7bc57b7

cmsbuild added this to the CMSSW_10_4_X milestone Nov 30, 2018

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures simulation-pending tests-pending labels Nov 30, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2018

cmsbuild added tests-approved and removed tests-started labels Nov 30, 2018

cmsbuild added comparison-available and removed comparison-pending labels Nov 30, 2018

makortel reviewed Nov 30, 2018

View reviewed changes

remove types

b424bc4

cmsbuild added code-checks-pending and removed code-checks-approved comparison-available tests-approved labels Nov 30, 2018

cmsbuild added comparison-pending tests-pending labels Nov 30, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Nov 30, 2018

cmsbuild added tests-started and removed tests-pending labels Nov 30, 2018

cmsbuild added tests-approved and removed tests-started labels Nov 30, 2018

cmsbuild added comparison-available and removed comparison-pending labels Nov 30, 2018

cmsbuild added fully-signed simulation-approved and removed pending-signatures simulation-pending labels Dec 2, 2018

cmsbuild added orp-approved and removed orp-pending labels Dec 3, 2018

cmsbuild merged commit 7523cc1 into cms-sw:master Dec 3, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix TrackTimeValueProducer inputs for premixing #25383

fix TrackTimeValueProducer inputs for premixing #25383

kpedro88 commented Nov 30, 2018

kpedro88 commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 •

edited

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

makortel Nov 30, 2018

makortel Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

kpedro88 commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 •

edited

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

civanch commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

fabiocos commented Dec 3, 2018

fix TrackTimeValueProducer inputs for premixing #25383

fix TrackTimeValueProducer inputs for premixing #25383

Conversation

kpedro88 commented Nov 30, 2018

kpedro88 commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 • edited

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

makortel Nov 30, 2018

Choose a reason for hiding this comment

makortel Nov 30, 2018

Choose a reason for hiding this comment

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

kpedro88 commented Nov 30, 2018

cmsbuild commented Nov 30, 2018 • edited

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

cmsbuild commented Nov 30, 2018

civanch commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

fabiocos commented Dec 3, 2018

cmsbuild commented Nov 30, 2018 •

edited

cmsbuild commented Nov 30, 2018 •

edited