Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

edmStreamStallGrapher.py timings only count module Event times #25394

Merged
merged 1 commit into from Dec 3, 2018
Merged

edmStreamStallGrapher.py timings only count module Event times #25394

merged 1 commit into from Dec 3, 2018

Conversation

gartung
Copy link
Member

@gartung gartung commented Nov 30, 2018

No description provided.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @gartung (Patrick Gartung) for master.

It involves the following packages:

FWCore/Concurrency

@cmsbuild, @smuzaffar, @Dr15Jones can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @wddgit this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor

fabiocos commented Dec 1, 2018

please test

not really checking this PR but...

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31932/console Started: 2018/12/01 20:10

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 1, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25394/31932/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131839
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131633
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@Dr15Jones
Copy link
Contributor

+1
this change only affects the creation of the yaml files.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 3, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 3, 2018

+1

@cmsbuild cmsbuild merged commit 1f8f608 into cms-sw:master Dec 3, 2018
@gartung gartung deleted the FWCore-Concurrency-edmStreamStallGrapher-update branch December 4, 2018 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants