ECAL : New method for MC production : outliers treatment. Legacy Run2. #25396

depasse · 2018-12-02T17:58:07Z

Use data Pedestals for MC production, correcting outliers by rings to Mean rings.
Legacy Run2 : all the G1/G6 files now completed.

cmsbuild · 2018-12-02T17:58:28Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-12-02T18:01:28Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25396/7431

cmsbuild · 2018-12-02T18:01:47Z

A new Pull Request was created by @depasse for master.

It involves the following packages:

CondTools/Ecal

@ggovi, @cmsbuild can you please review it and eventually sign? Thanks.
@mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

ggovi · 2018-12-04T13:44:42Z

please test

cmsbuild · 2018-12-04T13:44:57Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/31981/console Started: 2018/12/04 14:45

ggovi · 2018-12-04T13:48:28Z

CondTools/Ecal/src/EcalPedestalsHandler.cc


-	std::cout << m_sid<<"/"<<m_user<<"/"<<m_pass<<"/"<<m_location<<"/"<<m_gentag   << std::endl;
+	edm::LogInfo("EcalPedestalsHandler")<<m_sid<<"/"<<m_user<<"/"<<m_pass<<"/"<<m_location<<"/"<<m_gentag;


Please remove the printout of the password

cmsbuild · 2018-12-04T15:08:40Z

The code-checks are being triggered in jenkins.

cmsbuild · 2018-12-04T15:11:42Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25396/7464

cmsbuild · 2018-12-04T15:12:02Z

Pull request #25396 was updated. @ggovi, @cmsbuild can you please check and sign again.

boudoul · 2018-12-04T15:16:45Z

Hello @depasse , could you please edit the title and mention the word "ecal" somewhere in the title, so that it is clear in the release notes that this not a generic infrastructure PR (or we no do wonder if this is for tracker, hcal etc.. ) thank you .

cmsbuild · 2018-12-04T16:07:44Z

+1
Tested at: e3a89b6
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25396/31981/summary.html

cmsbuild · 2018-12-04T16:07:48Z

Comparison job queued.

cmsbuild · 2018-12-04T17:50:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25396/31981/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131939
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131734
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ggovi · 2018-12-05T13:48:05Z

please test

cmsbuild · 2018-12-05T13:48:20Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32009/console Started: 2018/12/05 14:48

cmsbuild · 2018-12-05T15:58:31Z

+1
Tested at: e594893
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25396/32009/summary.html

cmsbuild · 2018-12-05T15:58:35Z

Comparison job queued.

cmsbuild · 2018-12-05T17:33:35Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25396/32009/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 33
DQMHistoTests: Total histograms compared: 3131939
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3131734
DQMHistoTests: Total skipped: 204
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
Checked 137 log files, 14 edm output root files, 33 DQM output files

ggovi · 2018-12-10T10:36:51Z

+1

cmsbuild · 2018-12-10T10:37:08Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2018-12-11T12:12:13Z

+1

New method for MC production : outliers treatment. Legacy Run2.

e3a89b6

cmsbuild added this to the CMSSW_10_4_X milestone Dec 2, 2018

cmsbuild added code-checks-pending comparison-pending db-pending orp-pending pending-signatures tests-pending labels Dec 2, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 2, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 4, 2018

ggovi reviewed Dec 4, 2018

View reviewed changes

New method for MC production : outliers treatment. Legacy Run2.

e594893

cmsbuild added code-checks-pending tests-pending and removed code-checks-approved tests-started labels Dec 4, 2018

cmsbuild added code-checks-approved and removed code-checks-pending labels Dec 4, 2018

depasse changed the title ~~New method for MC production : outliers treatment. Legacy Run2.~~ ECAL : New method for MC production : outliers treatment. Legacy Run2. Dec 4, 2018

cmsbuild added tests-started and removed tests-pending labels Dec 5, 2018

cmsbuild added tests-approved and removed tests-started labels Dec 5, 2018

cmsbuild added comparison-available and removed comparison-pending labels Dec 5, 2018

cmsbuild added db-approved fully-signed and removed db-pending pending-signatures labels Dec 10, 2018

cmsbuild added orp-approved and removed orp-pending labels Dec 11, 2018

cmsbuild merged commit 23c90f4 into cms-sw:master Dec 11, 2018

depasse deleted the EcalPedestalsLegacyRun2 branch January 11, 2023 08:34

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

ECAL : New method for MC production : outliers treatment. Legacy Run2. #25396

ECAL : New method for MC production : outliers treatment. Legacy Run2. #25396

depasse commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

ggovi commented Dec 4, 2018

cmsbuild commented Dec 4, 2018 •

edited

ggovi Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

boudoul commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

ggovi commented Dec 5, 2018

cmsbuild commented Dec 5, 2018 •

edited

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

ggovi commented Dec 10, 2018

cmsbuild commented Dec 10, 2018

fabiocos commented Dec 11, 2018


		std::cout << m_sid<<"/"<<m_user<<"/"<<m_pass<<"/"<<m_location<<"/"<<m_gentag << std::endl;
		edm::LogInfo("EcalPedestalsHandler")<<m_sid<<"/"<<m_user<<"/"<<m_pass<<"/"<<m_location<<"/"<<m_gentag;

ECAL : New method for MC production : outliers treatment. Legacy Run2. #25396

ECAL : New method for MC production : outliers treatment. Legacy Run2. #25396

Conversation

depasse commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

cmsbuild commented Dec 2, 2018

ggovi commented Dec 4, 2018

cmsbuild commented Dec 4, 2018 • edited

ggovi Dec 4, 2018

Choose a reason for hiding this comment

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

boudoul commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

cmsbuild commented Dec 4, 2018

ggovi commented Dec 5, 2018

cmsbuild commented Dec 5, 2018 • edited

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

cmsbuild commented Dec 5, 2018

ggovi commented Dec 10, 2018

cmsbuild commented Dec 10, 2018

fabiocos commented Dec 11, 2018

cmsbuild commented Dec 4, 2018 •

edited

cmsbuild commented Dec 5, 2018 •

edited