Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obvious bug in particle boosting - backport of PR #25412 in 10.2.X for actual MC generation #25424

Merged
merged 2 commits into from Dec 9, 2018

Conversation

covarell
Copy link
Contributor

@covarell covarell commented Dec 5, 2018

No description provided.

@covarell
Copy link
Contributor Author

covarell commented Dec 5, 2018

Backport of #25412

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

A new Pull Request was created by @covarell (Roberto Covarelli) for CMSSW_10_2_X.

It involves the following packages:

GeneratorInterface/GenFilters

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32003/console Started: 2018/12/05 12:57

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25424/32003/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007299
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007105
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_4_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

@alberto-sanchez could you please provide a bit more informative title?

@alberto-sanchez
Copy link
Member

@covarell , can you edit the title, I do not have access to it
"Fix obvious bug in particle boosting - backport of #25412"
or something similar

@fabiocos fabiocos changed the title Backport of PR #25412 in 10.2.X for actual MC generation Fix obvious bug in particle boosting - backport of PR #25412 in 10.2.X for actual MC generation Dec 9, 2018
@fabiocos
Copy link
Contributor

fabiocos commented Dec 9, 2018

+1

@cmsbuild cmsbuild merged commit b7a078d into cms-sw:CMSSW_10_2_X Dec 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants