Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for cavern #25427

Merged
merged 1 commit into from Dec 7, 2018
Merged

Bugfix for cavern #25427

merged 1 commit into from Dec 7, 2018

Conversation

slomeo
Copy link
Contributor

@slomeo slomeo commented Dec 5, 2018

Geometry 2018: Update Cavern and mb4shields for neutrons

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

A new Pull Request was created by @slomeo (Sergio Lo Meo) for master.

It involves the following packages:

Geometry/CMSCommonData

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild, @kpedro88 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor

ianna commented Dec 5, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32014/console Started: 2018/12/05 16:14

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25427/32014/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131939
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131734
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ianna
Copy link
Contributor

ianna commented Dec 6, 2018

+1

@kpedro88
Copy link
Contributor

kpedro88 commented Dec 6, 2018

+upgrade

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 6, 2018

@ianna @cvuosalo @slomeo this is for special studies, that configuration was already used in productions?

@slomeo
Copy link
Contributor Author

slomeo commented Dec 6, 2018

@ianna @cvuosalo @slomeo this is for special studies, that configuration was already used in productions?

No, I have never used it for a production. When a (little) MC sample ,with Geo2018 (updated cavern and mb4shields) will be done, and it will be ok (now I have seen a too high background rate, perhaps because there was not a detailed cavern) I will request a central production.

@fabiocos
Copy link
Contributor

fabiocos commented Dec 7, 2018

+1

@cmsbuild cmsbuild merged commit 14d4e71 into cms-sw:master Dec 7, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
@slomeo slomeo deleted the Cavern2018Fix branch January 31, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants