Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken include guard in L1TMuonBarrelKalmanLUTs #25430

Merged
merged 1 commit into from Dec 6, 2018

Conversation

Dr15Jones
Copy link
Contributor

Also made the guard conform to CMS standards.
The problem was uncovered by clang.

Also made the guard conform to CMS standards.
The problem was uncovered by clang.
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

L1Trigger/L1TMuonBarrel

@nsmith-, @rekovic, @cmsbuild, @thomreis can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @thomreis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32021/console Started: 2018/12/05 17:48

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison job queued.

@thomreis
Copy link
Contributor

thomreis commented Dec 5, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 5, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25430/32021/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131939
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131734
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 6, 2018

+1

@cmsbuild cmsbuild merged commit f246f43 into cms-sw:master Dec 6, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
…arrel

Fixed broken include guard in L1TMuonBarrelKalmanLUTs
@Dr15Jones Dr15Jones deleted the clangL1TriggerL1TMuonBarrel branch December 10, 2018 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants