Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD: Add PMTDParameters to the GeometryObjects serialization test #25433

Merged
merged 1 commit into from Dec 11, 2018

Conversation

fabiocos
Copy link
Contributor

@fabiocos fabiocos commented Dec 6, 2018

Addition of PMTDParameters to the unit test for serialization in CondFormats/GeometryObjects. Descoped in #25417 to speed it up, added back here as non critical (but still useful).

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

The code-checks are being triggered in jenkins.

@fabiocos fabiocos changed the title Add PMTDParameters to the GeometryObjects serialization test MTD: Add PMTDParameters to the GeometryObjects serialization test Dec 6, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

CondFormats/GeometryObjects

@tocheng, @cmsbuild, @franzoni, @ggovi, @pohsun, @lpernie can you please review it and eventually sign? Thanks.
@mmusich, @tocheng, @seemasharmafnal this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

fabiocos commented Dec 6, 2018

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32031/console Started: 2018/12/06 10:19

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 6, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25433/32031/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3131939
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3131734
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@pohsun
Copy link

pohsun commented Dec 10, 2018

+1

@ggovi
Copy link
Contributor

ggovi commented Dec 10, 2018

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

+1

@cmsbuild cmsbuild merged commit fffd496 into cms-sw:master Dec 11, 2018
@fabiocos fabiocos deleted the fc-addCondFormatTest branch December 14, 2018 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants