Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix clang warnings in MuonAnalysis/MomentumScaleCalibration #25450

Merged
merged 1 commit into from Dec 10, 2018
Merged

fix clang warnings in MuonAnalysis/MomentumScaleCalibration #25450

merged 1 commit into from Dec 10, 2018

Conversation

Dr15Jones
Copy link
Contributor

Fixed virtual function hiding.
This was found by clang.

@Dr15Jones
Fixed virtual function hiding
5123d91 
This was found by clang.
@cmsbuild cmsbuild added this to the CMSSW_10_4_X milestone Dec 7, 2018
@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25450/7528

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

MuonAnalysis/MomentumScaleCalibration

@cmsbuild, @fgolf, @peruzzim, @monttj can you please review it and eventually sign? Thanks.
@bellan, @mmusich, @argiro this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018 •
edited

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32066/console Started: 2018/12/07 20:16

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

+1
Tested at: 5123d91
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25450/32066/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25450/32066/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136217
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 8, 2018

+1

@fabiocos
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 677b794 into cms-sw:master Dec 10, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
@cmsbuild
Merge pull request cms-sw#25450 from Dr15Jones/clangMuonAnalysisMomen…
c1000bc 
…tumScaleCalibrartion

fix clang warnings in MuonAnalysis/MomentumScaleCalibration
@Dr15Jones Dr15Jones deleted the clangMuonAnalysisMomentumScaleCalibrartion branch December 10, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
analysis-pending code-checks-approved comparison-available orp-approved pending-signatures tests-approved
Projects
None yet
Milestone
CMSSW_10_4_X
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Dr15Jones @cmsbuild @fabiocos