Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate entry in Geometry/GlobalTrackingGeometryBuilder/test/BuildFile.xml #25451

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 7, 2018

Removes the following warning from scram

***WARNING: Multiple usage of "Geometry/TrackerGeometryBuilder". Please cleanup "use" in "non-export" section of "src/Geometry/GlobalTrackingGeometryBuilder/test/BuildFile".

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

Geometry/GlobalTrackingGeometryBuilder

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 7, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32067/console Started: 2018/12/07 20:21

@cvuosalo
Copy link
Contributor

cvuosalo commented Dec 7, 2018

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs after it passes the integration tests. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25451/32067/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136217
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@fabiocos
Copy link
Contributor

fabiocos commented Dec 8, 2018

+1

@cmsbuild cmsbuild merged commit 5b61323 into cms-sw:master Dec 8, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
…ngGeometryBuilderBuildFile

Remove duplicate entry in Geometry/GlobalTrackingGeometryBuilder/test/BuildFile.xml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants