Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clang warnings in TrackingTools/PatternTools #25454

Merged
merged 1 commit into from Dec 8, 2018

Conversation

makortel
Copy link
Contributor

@makortel makortel commented Dec 7, 2018

Clang complained about six unused file-local functions.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

TrackingTools/PatternTools

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@battibass, @felicepantaleo, @abbiendi, @GiacomoSguazzoni, @jhgoh, @VinInn, @calderona, @HuguesBrun, @ebrondol, @rovere, @gpetruc, @bellan, @trocino, @dgulhan, @folguera this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@makortel
Copy link
Contributor Author

makortel commented Dec 7, 2018

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32073/console Started: 2018/12/07 22:06

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 7, 2018

Comparison job queued.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25454/32073/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3136422
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3136216
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@perrotta
Copy link
Contributor

perrotta commented Dec 8, 2018

+1

  • Technical
  • Jenkins tests pass
  • (Would those functionalities really be needed, they should be better included in the GlobalPoint itself)

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 8, 2018

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Dec 8, 2018

+1

@cmsbuild cmsbuild merged commit ed3bfda into cms-sw:master Dec 8, 2018
forthommel pushed a commit to forthommel/cmssw that referenced this pull request Dec 10, 2018
…tternTools

Fix clang warnings in TrackingTools/PatternTools
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants