Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Sherpa ttbar+2j GEN Relval workflow 536 #25461

Merged
merged 2 commits into from Jan 9, 2019

Conversation

SanghyunKo
Copy link
Contributor

Adding Sherpa ttbar@NLO + 2 LO jets (MENLOPS) GEN Relval workflow as discussed in GEN meeting.

(Currently, only ZtoEE process is available for Sherpa Relval (workflow 534).)

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @SanghyunKo (Sanghyun Ko) for master.

It involves the following packages:

Configuration/Generator
Configuration/PyReleaseValidation

@cmsbuild, @efeyazgan, @zhenhu, @perrozzi, @prebello, @kpedro88, @pgunnell, @alberto-sanchez, @qliphy can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@efeyazgan
Copy link
Contributor

I thought we asked for a simpler process for the relval.

@efeyazgan
Copy link
Contributor

Adding @GurpreetSinghChahal

@SanghyunKo
Copy link
Contributor Author

Hi @efeyazgan, I reduced number of jets and the order of jets. Now event generation only takes ~0.7s/event, so I assumed that the process is simple enough for the relval. However, I can replace python fragment & sherpack for simpler and more generic one if you want.

@smuzaffar
Copy link
Contributor

@SanghyunKo , we did a cleanup of some large data files which were merge in cmssw repo few days ago. Due to this cleanup this PR is now in a bad state (includes all the commits which we rewrite to avoid the large data files), Can you please rebase this PR based on new head?

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25461/32215/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

  • /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25461/536.0_sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+sherpa_ttbar_2j_MENLOPS_13TeV_MASTER+HARVESTGEN

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 2
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153511
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Dec 17, 2018

+1

@kpedro88
Copy link
Contributor

+upgrade

@SanghyunKo
Copy link
Contributor Author

Hi @zhenhu, @prebello, could you please check this and sign?

@prebello
Copy link
Contributor

prebello commented Jan 8, 2019

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Jan 9, 2019

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25461/7880

  • This PR adds an extra 60KB to repository

@fabiocos
Copy link
Contributor

fabiocos commented Jan 9, 2019

+1

@cmsbuild cmsbuild merged commit 52388f2 into cms-sw:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants