Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New training for anti-e tau-Id (94X) #25488

Merged
merged 6 commits into from Jan 16, 2019

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Dec 12, 2018

This PR adds configuration with payloads of a new training of anti-e tau-Id, backport of #25486 to 94X.

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 12, 2018

A new Pull Request was created by @mbluj for CMSSW_9_4_X.

It involves the following packages:

RecoTauTag/Configuration
RecoTauTag/RecoTau

@perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

Pull request #25488 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2018

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32250/console Started: 2018/12/18 14:43

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25488/32250/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 111
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721220
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@perrotta
Copy link
Contributor

This is an almost identical backport of #25486 from the master into 94X: it just misses to backport the two files:

  • RecoTauTag/RecoTau/python/tools/runTauIdMVA.py
  • RecoTauTag/RecoTau/test/runDeepTauIDsOnMiniAOD.py
    This makes sense, because runTauIdMVA.py was not yet updated and moved into the tools folder in 94X.

Even if not including the tool to run and test the new ID in 94X, however this PR sets up for it in that release. Full backport to 94X will be completed when DNN-tauID (and tau tools) will be finally merged to that release.

@perrotta
Copy link
Contributor

@mbluj (maybe you already told us, but I forgot it, sorry for that...): is there any plan to update this PR once #25385 will get merged in 94X?

@perrotta
Copy link
Contributor

backport of #25486

@mbluj
Copy link
Contributor Author

mbluj commented Dec 31, 2018

@mbluj (maybe you already told us, but I forgot it, sorry for that...): is there any plan to update this PR once #25385 will get merged in 94X?

Yes, the plan is either to update this PR or prepare a new one on top of it depending what is more convenient, i.e. in which order this PR and #25385 are merged.

@cmsbuild
Copy link
Contributor

Pull request #25488 was updated. @perrotta, @cmsbuild, @slava77 can you please check and sign again.

@perrotta
Copy link
Contributor

please test
(now #25621 is in the 94X IBs)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 12, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32548/console Started: 2019/01/12 09:59

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25488/32548/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 27
  • DQMHistoTests: Total histograms compared: 2721493
  • DQMHistoTests: Total failures: 118
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2721213
  • DQMHistoTests: Total skipped: 162
  • DQMHistoTests: Total Missing objects: 0

@perrotta
Copy link
Contributor

+1

  • Identical backport of New training for anti-e tau-Id #25486
  • A new anti-e tau-ID defined is added to tau tools for user convenience, but disabled by default: non difference expected in regular workflows and reco sequences
  • Jenkins tests pass and show no differences

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25488/8034

  • This PR adds an extra 28KB to repository

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2d0046f into cms-sw:CMSSW_9_4_X Jan 16, 2019
@mbluj mbluj deleted the CMSSW_9_4_X_antiEDiscUpdate branch March 13, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants