Fix clang warnings in Fireworks #25520
Conversation
This inconsistency was found by clang
This silences a clang warning.
The file fwPaletteClassic.cc was only being included into FWCoreManager and defined some static values. clang was issuing a warning for unused variables when fwPaletteClassic.cc was compiled by itself. Changing the postfix will stop the file from being compiled.
|
The code-checks are being triggered in jenkins. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25520/7713 |
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for master. It involves the following packages: Fireworks/Core @cmsbuild, @alja, @Dr15Jones can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
|
please test |
|
The tests are being triggered in jenkins. |
|
Comparison not run due to Fireworks only changes in PR (RelVals and Igprof tests were also skipped) |
cmsbuild
added
comparison-notrun
tests-approved
and removed
comparison-pending
tests-started
labels
|
+1 |
cmsbuild
added
fully-signed
visualization-approved
and removed
pending-signatures
visualization-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
No description provided.