-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix for GED electron MVA preselection calculator #2558
Conversation
A new Pull Request was created by @lgray (Lindsey Gray) for CMSSW_7_1_X. Bug fix for GED electron MVA preselection calculator It involves the following packages: RecoEgamma/ElectronIdentification @nclopezo, @cmsbuild, @anton-a, @thspeer, @slava77, @Degano can you please review it and eventually sign? Thanks. |
Hi Lindsey, could you please post some comparison plots describing the changes here so that we roughly know what to expect in testing and, maybe more importantly, to have a reference for the release history Thanks. |
Hi Slava, |
@lgray we would need as usual to update the weight file in a second moment. Thanks. |
Hi Daniele and Lindsey, please clarify on your comment about the weight file. The file is in the external: was the request for an update submitted? Thanks |
Hi Slava, yes the plots are done with the new weight file. However it change very cheers, On 27/02/14 01:07, slava77 wrote:
|
Hi Daniele, |
Hi Lindsey Once cms-sw/cmsdist#465 is resolved and is in the IB, Giulio, is it too late for 05-0200 IB? |
Hi Slava, |
It was too late for me ;-) @Degano can you update the files? Thanks. |
Hi, |
Great. Thanks, Alessandro. |
@lgray |
@nclopezo now based on CMSSW_7_1_X_2014-03-05-0200 |
@Degano the changes you made broke the IB. Please add back the files you removed (creating a new cms-data). We should remove files only when they are not used anymore. |
checking it now |
RecoEgamma/ElectronIdentification -- Bug fix for GED electron MVA preselection calculator
Properly initialize and use some variables that were missed in the calculation of the electron preselection-mva.
These variables were present in the training, but not in the evaluation, so they carry some rejection power.
Small expected changes for tracker-driven only electrons, small improvements in efficiency/fake-rate.
Now includes #2717 and #2719 .
We should backport this to 700.