Do not register parameter set in a constructor #256
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a public constructor of ParameterSet that registers the constructed parameter set. This complicates thread safety, because it is hard to find instances of this particular constructor.
This pull request makes this constructor private, and removes the registration from this constructor. It adds a new public static function of ParameterSet (registerfromString) that invokes this constructor and registers the constructed parameter set.
The only place in CMSSW where this constructor is called is modified to call the new static function.
The new static function has the same thread safety issues as the constructor had previously, but it is much easier to find, and much less likely to be used inappropriately.