Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adapt Pythia8Interface to pythia8 240 #25602

Merged
merged 1 commit into from Feb 14, 2019

Conversation

mkirsano
Copy link
Contributor

@mkirsano mkirsano commented Jan 8, 2019

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

The code-checks are being triggered in jenkins.

@mkirsano
Copy link
Contributor Author

mkirsano commented Jan 8, 2019

To be tested together with PR cmsdist #4624

@mkirsano mkirsano changed the title adapt pythia8Interface to pythia8 240 adapt Pythia8Interface to pythia8 240 Jan 8, 2019
@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25602/7876

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

A new Pull Request was created by @mkirsano (Mikhail Kirsanov) for master.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@alberto-sanchez
Copy link
Member

please test with #4624

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32477/console Started: 2019/01/08 22:02

@alberto-sanchez
Copy link
Member

please abort

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

Jenkins tests are aborted.

@alberto-sanchez
Copy link
Member

please test with cms-sw/cmsdist#4624

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 8, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4624
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32478/console

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 9, 2019

Comparison job queued.

@fabiocos
Copy link
Contributor

@mkirsano @alberto-sanchez apparently there was an issue with the test, what is the integration plan here?

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 31, 2019

The tests are being triggered in jenkins.
Using externals from cms-sw/cmsdist#4624
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32920/console

@alberto-sanchez
Copy link
Member

Let's make sure it is not a glitch

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25602/32920/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 30842 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 194866
  • DQMHistoTests: Total nulls: 8
  • DQMHistoTests: Total successes: 2902369
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 435.69 KiB( 31 files compared)
  • DQMHistoSizes: changed ( 10224.0 ): -0.192 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 250202.181,... ): 218.555 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 250202.181 ): -0.782 KiB SiStrip/MechanicalView
  • DQMHistoSizes: changed ( 25202.0 ): -0.445 KiB SiStrip/MechanicalView
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@alberto-sanchez
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 2, 2019

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

fabiocos commented Feb 4, 2019

code-checks

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

cmsbuild commented Feb 4, 2019

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25602/8307

  • This PR adds an extra 16KB to repository

@fabiocos
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants