Pass ConsumesCollector to ModifyObjectValueBase-derived classes in the constructor

[makortel]

It was noticed in #25593 (comment) that ModifyObjectValueBase-derived classes (like pat::ObjectModifier) taking ConsumesCollector not via the constructor but via setConsumes() function call. This PR restructures ModifyObjectValueBase hierarchy such that the ConsumesCollector is passed via constructor.

Tested in CMSSW_10_5_X_2019-01-04-1100, no changes expected.

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25617/7907

• This PR adds an extra 60KB to repository

[makortel]

@cmsbuild, please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32503/console Started: 2019/01/09 20:54

[cmsbuild]

A new Pull Request was created by @makortel (Matti Kortelainen) for master.

It involves the following packages:

CommonTools/CandAlgos
PhysicsTools/PatAlgos
RecoEgamma/EgammaElectronProducers
RecoEgamma/EgammaPhotonAlgos
RecoEgamma/EgammaPhotonProducers
RecoEgamma/EgammaTools

@perrotta, @cmsbuild, @santocch, @slava77 can you please review it and eventually sign? Thanks.
@TaiSakuma, @gouskos, @jainshilpi, @rappoccio, @HeinerTholen, @varuns23, @seemasharmafnal, @mmarionncern, @imarches, @ahinzmann, @smoortga, @acaudron, @lgray, @jdolen, @drkovalskyi, @ferencek, @Sam-Harper, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @clelange, @JyothsnaKomaragiri, @mverzett, @gpetruc, @mariadalfonso, @pvmulder this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1
Tested at: b7b86a1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25617/32503/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25617/32503/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 33
• DQMHistoTests: Total histograms compared: 3153717
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3153512
• DQMHistoTests: Total skipped: 204
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
• Checked 137 log files, 14 edm output root files, 33 DQM output files

[perrotta]

@makortel did you check whether this PR doesn't disrupt any object to be used in FWlite?
(By the way, can anyone suggest me how to test it?)

[makortel]

@perrotta As far as I can tell, all products are retrieved with edm::Event::getByToken(), so the class hierarchy was already unusable from FWLite.

[cmsbuild]

The code-checks are being triggered in jenkins.

[makortel]

Sorry for the noise. I was thinking to do some other migration as well as part of this PR, but a closer look made me realize it is best to leave it to a subsequent PR. The force-push restored the earlier state.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25617/7992

• This PR adds an extra 64KB to repository

[perrotta]

+1

• It does what declared in the PR description
• Jekins tests pass and show no (relevant) differences

[fabiocos]

+1

[fabiocos]

merge