Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport of POWHEG EmissionVeto1 updates to 93X #25648

Merged

Conversation

AndrewLevin
Copy link
Contributor

This is a backport of pull request #24763 which updates the POWHEG EmissionVeto1 userhook for the WGamma special case.

This was already backported to 71X (#24828) for 2016 MC production, but we would also like to use it for 2017 MC production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 14, 2019

A new Pull Request was created by @AndrewLevin for CMSSW_9_3_X.

It involves the following packages:

GeneratorInterface/Pythia8Interface

@alberto-sanchez, @cmsbuild, @qliphy, @perrozzi, @efeyazgan can you please review it and eventually sign? Thanks.
@alberto-sanchez, @agrohsje, @mkirsano this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos, @kpedro88 you are the release manager for this.

cms-bot commands are listed here

@qliphy
Copy link
Contributor

qliphy commented Jan 15, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32599/console Started: 2019/01/15 06:36

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25648/32599/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 25
  • DQMHistoTests: Total histograms compared: 2624448
  • DQMHistoTests: Total failures: 223
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 2624048
  • DQMHistoTests: Total skipped: 177
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -24 KiB( 24 files compared)
  • Checked 105 log files, 8 edm output root files, 25 DQM output files

@qliphy
Copy link
Contributor

qliphy commented Jan 15, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_9_3_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos, @kpedro88 (and backports should be raised in the release meeting by the corresponding L2)

@kpedro88
Copy link
Contributor

backport of #24763

@kpedro88
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 0899ff5 into cms-sw:CMSSW_9_3_X Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants