New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DD4hep: Allow Multiple EventSetup Records #25652
Conversation
ianna
commented
Jan 14, 2019
- Add a product label to allow multiple producers
- Update configuration files
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25652/7987
|
A new Pull Request was created by @ianna (Ianna Osborne) for master. It involves the following packages: DetectorDescription/DDCMS @civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 @fabiocos - FYI, the differences in comparison results are not related to this PR |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
@ianna just one minor thing: do we want to keep all the "cout"s? For test plugins is likely not so important, but in case would not be better to move to MessageLogger? |
@fabiocos - I agree, I use cout for a quick feedback and will move to a MessageLogger for a production version of the ES producers. I find it's a bit of an overhead to have a MessageLogger configuration included for the tests. |
+1 |