Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DD4hep: Allow Multiple EventSetup Records #25652

Merged
merged 2 commits into from Jan 15, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 14, 2019

  • Add a product label to allow multiple producers
  • Update configuration files

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25652/7987

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

DetectorDescription/DDCMS

@civanch, @Dr15Jones, @cvuosalo, @ianna, @mdhildreth, @cmsbuild can you please review it and eventually sign? Thanks.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jan 15, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 15, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32605/console Started: 2019/01/15 07:26

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25652/32605/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 33
  • DQMHistoTests: Total histograms compared: 3153717
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3153512
  • DQMHistoTests: Total skipped: 204
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 32 files compared)
  • Checked 137 log files, 14 edm output root files, 33 DQM output files

@ianna
Copy link
Contributor Author

ianna commented Jan 15, 2019

+1

@fabiocos - FYI, the differences in comparison results are not related to this PR

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@ianna
Copy link
Contributor Author

ianna commented Jan 15, 2019

+1

@fabiocos
Copy link
Contributor

@ianna just one minor thing: do we want to keep all the "cout"s? For test plugins is likely not so important, but in case would not be better to move to MessageLogger?

@ianna
Copy link
Contributor Author

ianna commented Jan 15, 2019

@fabiocos - I agree, I use cout for a quick feedback and will move to a MessageLogger for a production version of the ES producers. I find it's a bit of an overhead to have a MessageLogger configuration included for the tests.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 98767f3 into cms-sw:master Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants