New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upating HCAL validation test for HTCondor batch submission #25678
Conversation
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25678/8023
|
A new Pull Request was created by @abdoulline (Salavat Abdullin) for master. It involves the following packages: Validation/CaloTowers @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
Hi @abdoulline Thank you for making these changes by the way. |
The code-checks are being triggered in jenkins. |
Hi @hatakeyamak |
Thank you. I just noticed about this missing file when I ran this workflow last time. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25678/8027
|
Pull request #25678 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again. |
please test |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
@abdoulline for my info, was this effectively tested on HTCondor? |
Yes, first it was made work and then committed.
Here is the test (HTCondor results vs regular LSF ones) :
https://cms-cpt-software.web.cern.ch/cms-cpt-software/General/Validation/SVSuite/HCAL/calo_scan_single_pi/10_X/10_4_0_pre4_testCondor1_vs_10_4_0_pre4_SinglePi/
…On Thu, 17 Jan 2019, Fabio Cossutti wrote:
@abdoulline for my info, was this effectively tested on HTCondor?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or mute the thread.[AEx02gzvIgwXsoSGGxBhzxgCAnCoP9DDks5vEGDFgaJpZM4aCXmY.gif]
|
+1 |
Widely used HCAL validation test is updated to use HTCondor for submitting batch jobs.
No any central workflow's affected.