Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upating HCAL validation test for HTCondor batch submission #25678

Merged
merged 2 commits into from Jan 17, 2019

Conversation

abdoulline
Copy link

@abdoulline abdoulline commented Jan 16, 2019

Widely used HCAL validation test is updated to use HTCondor for submitting batch jobs.
No any central workflow's affected.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25678/8023

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @abdoulline (Salavat Abdullin) for master.

It involves the following packages:

Validation/CaloTowers

@kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please review it and eventually sign? Thanks.
@hatakeyamak this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@hatakeyamak
Copy link
Contributor

hatakeyamak commented Jan 16, 2019

Hi @abdoulline
It's not critical, but we are missing merging_cfi.py in Validation/CaloTowers/test/CaloScan/ ?

Thank you for making these changes by the way.

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@abdoulline
Copy link
Author

abdoulline commented Jan 16, 2019

Hi @hatakeyamak
Thank you for spotting this omission.
Indeed, somehow it wasn't included in the previous PR. I've just added it.

@hatakeyamak
Copy link
Contributor

Thank you. I just noticed about this missing file when I ran this workflow last time.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25678/8027

  • This PR adds an extra 16KB to repository

@cmsbuild
Copy link
Contributor

Pull request #25678 was updated. @kmaeshima, @cmsbuild, @andrius-k, @jfernan2, @schneiml can you please check and sign again.

@andrius-k
Copy link

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32645/console Started: 2019/01/16 15:20

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25678/32645/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@andrius-k
Copy link

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

@abdoulline for my info, was this effectively tested on HTCondor?

@abdoulline
Copy link
Author

abdoulline commented Jan 17, 2019 via email

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 4de9e40 into cms-sw:master Jan 17, 2019
@abdoulline abdoulline deleted the caloscan_HTCondor_update branch May 13, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants