Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Low pT electrons (up to GsfTracks) for 10_2_X #25680

Merged
merged 25 commits into from Jan 30, 2019

Conversation

bainbrid
Copy link
Contributor

This PR is equivalent to the open #25455 PR, but rebased to 10_2_X using a very recent IB.

This PR was opened in response to this instruction.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 16, 2019

A new Pull Request was created by @bainbrid for CMSSW_10_2_X.

It involves the following packages:

Configuration/Eras
Configuration/StandardSequences
FastSimulation/Tracking
RecoEgamma/Configuration
RecoEgamma/EgammaElectronProducers
RecoParticleFlow/PFTracking

@perrotta, @ssekmen, @lveldere, @civanch, @mdhildreth, @cmsbuild, @franzoni, @slava77, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@varuns23, @mmarionncern, @Sam-Harper, @makortel, @felicepantaleo, @jainshilpi, @cbernet, @GiacomoSguazzoni, @rovere, @lgray, @Martin-Grunewald, @seemasharmafnal, @hatakeyamak, @matt-komm, @VinInn, @dgulhan, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@bainbrid
Copy link
Contributor Author

This PR depends on the BDT models included in cms-data/RecoEgamma-ElectronIdentification#10

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25680/32858/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 31
  • DQMHistoTests: Total histograms compared: 3007400
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3007207
  • DQMHistoTests: Total skipped: 190
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 30 files compared)
  • Checked 129 log files, 14 edm output root files, 31 DQM output files

@perrotta
Copy link
Contributor

+1

@fabiocos
Copy link
Contributor

code-checks

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@ssekmen
Copy link
Contributor

ssekmen commented Jan 30, 2019

+1

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25680/8221

  • This PR adds an extra 68KB to repository

  • Found files with invalid states:

    • Configuration/Eras/python/Modifier_BParking_cff.py:

@fabiocos
Copy link
Contributor

+operations

the update to have the similar functionality as in #25773 appears correct

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_10_5_X is complete. This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor

+1

the code, under validation in CMSSW_10_5_X (in a different tuning) is not activated in the normal Eras

@cmsbuild cmsbuild merged commit c02236e into cms-sw:CMSSW_10_2_X Jan 30, 2019
@bainbrid bainbrid deleted the LowPtElectrons_102X branch August 6, 2019 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants