Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly update empty process history #2569

Merged
merged 2 commits into from Feb 20, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Feb 20, 2014

This is a fix for a bug that has been in place since CMSSW_6_2_0, and another bug that was introduced by the first attempt at fixing this bug.
The original problem was hit by Erik Butz when he tried to read a file written with CMSSW_3_2_5.
For files written in CMSSW_5_0_0 and later, actual FED raw data is recorded as having been created in a process called "LHC" with a module label of "rawDataCollector". If a file written prior to CMSSW_5_0_0 is read in CMSSW_5_0_0 or later, this "LHC" process is added retroactively, which affects the process history. The process history must then be retroactively modified.
This worked fine until CMSSW_6_2_0, when a bug was introduced. There is a map used to map the old process history to the new. In 6_2_0, the entry for an empty old process history was incorrectly omitted from the map. Real raw data prior to CMSSW_5_0_0 had an empty process history. So, the process history ID for real raw data was not found in the map. and a fatal assert fired.
The fix is to simply add the missing entry to the map.
The second problem was introduced a few days ago by an incorrect attempt to fix the above problem.
The second problem caused the failure of two relvals (4.6 and 144.6) and one other test (read312RV).
The fix for the second problem is just to back out the bad fix. That commit is also included in this pull request.

ktf added a commit that referenced this pull request Feb 20, 2014
Framework fixes -- Properly update empty process history
@ktf ktf merged commit 8e26d6e into cms-sw:CMSSW_7_1_X Feb 20, 2014
@wmtan wmtan deleted the ProperlyUpdateEmptyProcessHistoryID branch February 21, 2014 19:42
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

Properly update empty process history

It involves the following packages:

FWCore/Sources
IOPool/Input

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants