New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix HitPattern::stripHitFilter() #25692
Fix HitPattern::stripHitFilter() #25692
Conversation
After moving to the interface with TrackerTopology, this code ended up using the appendHit(const uint16_t pattern, TrackingRecHit::Type hitType) overload. The problem was found with clang.
Fixes the failing unit test.
The code-checks are being triggered in jenkins. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25692/8062
|
A new Pull Request was created by @makortel (Matti Kortelainen) for master. It involves the following packages: DataFormats/TrackReco @perrotta, @cmsbuild, @slava77 can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
The tests are being triggered in jenkins. |
@makortel |
I think so. |
assign upgrade |
New categories assigned: upgrade @kpedro88 you have been requested to review this Pull request/Issue and eventually sign? Thanks |
@lgray FYI |
@makortel @VinInn @mtosi @JanFSchulte Perhaps someone should put a similar picture for the phase-2 tracker in cmssw/DataFormats/TrackReco/interface/HitPattern.h Lines 22 to 40 in b2554f7
|
Yes, the phase2 OT barrel is treated as TOB and endcap as TID as noted in |
please test |
The tests are being triggered in jenkins. |
The tests are being triggered in jenkins. |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
This probably needs a backport for 10_4_X, isn't it? |
The
HitPattern::stripHitFilter()
was counting the MTD hits as well. This PR limits the function to only the strip detectors.The problem was found with clang (essentially) complaining the unit test using incorrect overload for
HitPattern::appendHit()
, and adding asserts in addition to the printouts (that would have indicated the problem of wrong overload already in #9959, and the need for an update in #24419).Tested in CMSSW_10_5_X_2019-01-13-0000, not sure if there are changes in downstream.
@mtosi @JanFSchulte @VinInn