Pixel Stuck TBM simulation: check conditions in digitizer initialization

[mmusich]

As pointed out in #25524 (comment), the conditions used for the stuck-TBM simulation tests (wf: 10824.7,10842.7) are inconsistent as there are some non-zero probabilities (in SiPixelStatusScenarioProbabilityRcd) assigned to certain scenarios which are not included in the scenario DB object (SiPixelStatusScenariosRcd).
The new payload proposed in eb2c2ec fixes this, while commit 986a13d takes care of throwing in case of an inconsistent sets of conditions at the pixel digitizer initialization instead that starting the job and eventually failing later randomly.
Tested in CMSSW_10_5_X_2019-01-17-1100 (architecture: slc7_amd64_gcc700) via:

dasgoclient --query 'file dataset=/RelValZMM_13/CMSSW_10_3_0_pre5-103X_upgrade2018_realistic_v7-v1/GEN-SIM' > step1_dasquery.log 
cmsDriver.py step2 --conditions auto:phase1_2018_realistic -n 100 --era Run2_2018 --eventcontent FEVTDEBUGHLT -s DIGI:pdigi_valid,L1,DIGI2RAW,HLT:@relval2018 --datatier GEN-SIM-DIGI-RAW --customise SimTracker/SiPixelDigitizer/customiseStuckTBMSimulation.activateStuckTBMSimulation2018NoPU --geometry DB:Extended --filein filelist:step1_dasquery.log --fileout file:step2.root --nThreads 4

(as in the failing tests: link )

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25700/8076

• This PR adds an extra 36KB to repository

Code check has found code style and quality issues which could be resolved by applying a patch in https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25700/8076/git-diff.patch
e.g. curl https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25700/8076/git-diff.patch | patch -p1

You can run scram build code-checks to apply code checks directly

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25700/8078

• This PR adds an extra 40KB to repository

[cmsbuild]

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

SimTracker/SiPixelDigitizer

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @ebrondol, @threus, @dgulhan this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[makortel]

@cmsbuild, please test workflow 10824.7,10842.7

Thanks @mmusich!

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32700/console Started: 2019/01/18 16:55

[cmsbuild]

+1
Tested at: d24ccc1
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25700/32700/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25700/32700/summary.html

@slava77 comparisons for the following workflows were not done due to missing matrix map:

• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25700/10824.7_TTbar_13+TTbar_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018
• /build/cmsbld/jenkins/workspace/compare-root-files-short-matrix/results/JR-comparison/PR-25700/10842.7_ZMM_13+ZMM_13TeV_TuneCUETP8M1_2018_GenSimFull+DigiFull_killStuckTBM_2018+RecoFull_2018+HARVESTFull_2018+ALCAFull_2018+NanoFull_2018

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[mmusich]

@civanch can you please check and eventually sign? This would be needed to have a working set of "stuck TBM" simulation relvals in IB (currently there are broken, see PR description)

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[fabiocos]

code-checks

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25700/8139

• This PR adds an extra 40KB to repository

[fabiocos]

+1