Remove unused instance of TrajectoryStateTransform

[perrotta]

This could replace #25742 by simply removing the unneeded instance
@Dr15Jones do you see any counterindication?

[cmsbuild]

The code-checks are being triggered in jenkins.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25750/8149

• This PR adds an extra 12KB to repository

[cmsbuild]

A new Pull Request was created by @perrotta for master.

It involves the following packages:

RecoParticleFlow/PFSimProducer

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@mmarionncern, @hatakeyamak, @lgray, @seemasharmafnal, @cbernet, @bachtis this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

[perrotta]

please test

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32799/console Started: 2019/01/23 18:36

[cmsbuild]

+1
Tested at: 44d3220
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25750/32799/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25750/32799/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 14 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

Uhm... The tests show a difference in the conversion output in wf 25, where one less conversion is present with respect to the baseline. That's curious...

[slava77]

On 1/23/19 1:42 PM, perrotta wrote: Uhm... The tests show a difference in the conversion output in wf 25, where one less conversion is present with respect to the baseline. That's curious... —

this might be random. perhaps try again with the next IB; it may go away.

[perrotta]

please test
(Let retry in a fresher IB. I think the difference observed are unrelated, since they show up identically in the tests of other, uncorrelated pull requests, e.g. #25741. I was initially puzzled because this PR does touch a conversion related plugin, even though such a plugin doesn't seem to be used anywhere as of now by now.)

[cmsbuild]

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32807/console Started: 2019/01/24 07:55

[cmsbuild]

+1
Tested at: 44d3220
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25750/32807/summary.html

[cmsbuild]

Comparison job queued.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25750/32807/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[perrotta]

+1

• Technical
• (The plugin doesn't look to be used anywhere in CMSSW by now, anyhow)
• Jenkins tests pass

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25750/32807/summary.html

Comparison Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 32
• DQMHistoTests: Total histograms compared: 3097440
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3097242
• DQMHistoTests: Total skipped: 197
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
• Checked 133 log files, 14 edm output root files, 32 DQM output files

[fabiocos]

+1