Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track finding am sv 210214 #2577

Merged
merged 5 commits into from Feb 24, 2014

Conversation

sviret
Copy link
Contributor

@sviret sviret commented Feb 21, 2014

Adding the latest developments to the package L1Trigger/TrackFindingAM

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @sviret (Seb Viret) for CMSSW_6_2_X_SLHC.

Track finding am sv 210214

It involves the following packages:

L1Trigger/TrackFindingAM

@cmsbuild, @Degano, @mulhearn, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@andersonjacob, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link

I get compilation errors:

>> Compiling edm plugin /tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc 
In file included from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:78:0:
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/poison/TrackingTools/TrackAssociator/interface/TrackDetectorAssociator.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:102:4: error: 'TrackDetectorAssociator' does not name a type
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:103:4: error: 'TrackAssociatorParameters' does not name a type
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc: In constructor 'TestIsoSimTracks::TestIsoSimTracks(const edm::ParameterSet&)':
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:141:4: error: 'trackAssociatorParameters_' was not declared in this scope
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:142:4: error: 'trackAssociator_' was not declared in this scope
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc: In member function 'virtual void TestIsoSimTracks::analyze(const edm::Event&, const edm::EventSetup&)':
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:198:7: error: 'TrackDetMatchInfo' was not declared in this scope
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:198:25: error: expected ';' before 'info'
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:212:27: error: 'info' was not declared in this scope
In file included from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Vector/RotationX.icc:11:0,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Vector/RotationX.h:283,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Vector/Rotation.h:30,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Geometry/Transform3D.icc:6,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Geometry/Transform3D.h:840,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/Geometry/CaloGeometry/interface/CaloCellGeometry.h:8,
                 from /afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/cms/cmssw/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/Geometry/CaloGeometry/interface/CaloSubdetectorGeometry.h:8,
                 from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:56:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Units/PhysicalConstants.h: At global scope:
/afs/cern.ch/cms/sw/ReleaseCandidates/vol1/slc5_amd64_gcc472/external/clhep/2.1.3.1-cms2/include/CLHEP/Units/PhysicalConstants.h:80:21: error: 'CLHEP::electron_charge' defined but not used [-Werror=unused-variable]
cc1plus: some warnings being treated as errors
In file included from /tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/src/JetMETCorrections/IsolatedParticles/test/TestIsoSimTracks.cc:78:0:
/tmp/grimes/CMSSW_6_2_X_SLHC_2014-02-23-1400/poison/TrackingTools/TrackAssociator/interface/TrackDetectorAssociator.h:1:2: error: #error THIS FILE HAS BEEN REMOVED FROM THE PACKAGE.
gmake: *** [tmp/slc5_amd64_gcc472/src/JetMETCorrections/IsolatedParticles/test/testIsoSimTracks/TestIsoSimTracks.o] Error 1
gmake: *** [There are compilation/build errors. Please see the detail log above.] Error 2

Not sure why, TrackDetectorAssociator.h isn't part of the request. I'll try again on the next IB.

@cmsbuild
Copy link
Contributor

Pull request #2577 was updated. @cmsbuild, @Degano, @mulhearn, @nclopezo can you please check and sign again.

@sviret
Copy link
Contributor Author

sviret commented Feb 24, 2014

Yes, that's odd. In addition the only modified code in this pull request wrt 620_SLHC7 is in TrackFindingAM, where TrackAssociator is not used, apart in the python configuration scripts (/python/ dir and /test/ dir).

@mark-grimes
Copy link

merge

No idea how I got the previous build errors. Tests 10000, 10200, 10400, 11200, 11400, 11600, 11800 and 12000 pass all steps. 12200, 12400, 12600, 12800 and 13000 pass step 1 (they fail in step 2 but that was the case beforehand).

cmsbuild added a commit that referenced this pull request Feb 24, 2014
@cmsbuild cmsbuild merged commit 31c1f78 into cms-sw:CMSSW_6_2_X_SLHC Feb 24, 2014
@sviret sviret deleted the TrackFindingAM_SV_210214 branch March 10, 2014 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants