Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Include Path Typo #25798

Merged
merged 1 commit into from Jan 31, 2019
Merged

Fix Include Path Typo #25798

merged 1 commit into from Jan 31, 2019

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jan 30, 2019

  • The // is not needed in the include path and it gives problems for LXR indexing the file

@smuzaffar - FYI

@cmsbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25798/8231

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna (Ianna Osborne) for master.

It involves the following packages:

SimG4CMS/Muon

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

@ianna
Copy link
Contributor Author

ianna commented Jan 30, 2019

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Jan 30, 2019

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32901/console Started: 2019/01/30 17:07

@gudrutis
Copy link
Contributor

While you are on to it, maybe you want to fix this as well ?

File name line
./RecoLocalCalo/EcalRecProducers/plugins/EcalUncalibRecHitWorkerRatio.h: #include "RecoLocalCalo/EcalRecAlgos/interface//EcalUncalibRecHitRatioMethodAlgo.h"
./RecoParticleFlow/PFClusterProducer/plugins/PFCTRecHitProducer.h: #include "CondFormats//HcalObjects/interface/HcalPFCorrs.h"
./SimG4CMS/FP420/plugins/FP420Test.cc: #include "SimG4CMS/FP420/interface//FP420NumberingScheme.h"
./SimG4CMS/FP420/plugins/FP420Test.cc: #include "SimG4CMS/FP420/interface//FP420G4HitCollection.h"
./SimG4CMS/Muon/src/MuonSensitiveDetector.cc: #include "SimG4CMS/Muon//interface/MuonEndcapFrameRotation.h"
./CondFormats/DataRecord/src/DropBoxMetadataRcd.cc: #include "CondFormats/DataRecord//interface/DropBoxMetadataRcd.h"
./CondFormats/DataRecord/src/DTRecoUncertaintiesRcd.cc: #include "CondFormats/DataRecord//interface/DTRecoUncertaintiesRcd.h"
./PhysicsTools/TagAndProbe/interface/TriggerCandProducer.h: #include "PhysicsTools/TagAndProbe//src/TriggerCandProducer.icc"
./RecoEgamma/EgammaTools/src/HGCalIsoCalculator.cc: #include "RecoEgamma/EgammaTools//interface/HGCalIsoCalculator.h"
./RecoEgamma/EgammaElectronAlgos/interface/ElectronSeedGenerator.h: #include "DataFormats/EgammaReco/interface//ElectronSeed.h"
./RecoTracker/TransientTrackingRecHit/plugins/TkTransientTrackingRecHitBuilderESProducer.h: #include "RecoLocalTracker/Records//interface/TrackerCPERecord.h"
./RecoTracker/SiTrackerMRHTools/interface/SimpleDAFHitCollector.h: #include "RecoTracker/SiTrackerMRHTools/interface//SiTrackerMultiRecHitUpdator.h"

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Comparison job queued.

@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25798/32901/summary.html

Comparison Summary:

  • No significant changes to the logs found
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 32
  • DQMHistoTests: Total histograms compared: 3097440
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3097242
  • DQMHistoTests: Total skipped: 197
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
  • Checked 133 log files, 14 edm output root files, 32 DQM output files

@civanch
Copy link
Contributor

civanch commented Jan 31, 2019

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

@civanch
Copy link
Contributor

civanch commented Jan 31, 2019

@gudrutis , these "//" inside source is a different story. Definitely should be fixed. Better if you post the list as an issue or alternatively make PRs with fixes per category.

@fabiocos
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 89ba5f3 into cms-sw:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants