Fix clang warnings in EventFilter/SiPixelRawToDigi #25805

Dr15Jones · 2019-01-30T19:47:45Z

No description provided.

cmsbuild · 2019-01-30T19:48:12Z

The code-checks are being triggered in jenkins.

cmsbuild · 2019-01-30T19:53:41Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25805/8239

This PR adds an extra 16KB to repository

cmsbuild · 2019-01-30T19:54:11Z

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

EventFilter/SiPixelRawToDigi

@cmsbuild, @perrotta, @slava77 can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @dkotlins, @VinInn this is something you requested to watch as well.
@davidlange6, @slava77, @fabiocos you are the release manager for this.

cms-bot commands are listed here

Dr15Jones · 2019-01-30T19:58:30Z

please test

cmsbuild · 2019-01-30T20:00:04Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/32911/console Started: 2019/01/30 21:01

cmsbuild · 2019-01-30T22:14:57Z

+1
Tested at: 1999bdb
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25805/32911/summary.html

cmsbuild · 2019-01-30T22:15:03Z

Comparison job queued.

cmsbuild · 2019-01-30T23:42:26Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25805/32911/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 0 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097242
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

slava77 · 2019-01-31T17:37:31Z

EventFilter/SiPixelRawToDigi/plugins/SiPixelDigiToRaw.cc

@@ -63,7 +63,7 @@ class SiPixelDigiToRaw final : public edm::global::EDProducer<edm::LuminosityBlo

 private:

-  mutable std::atomic_flag lock_{ ATOMIC_FLAG_INIT };
+  mutable std::atomic_flag lock_ = ATOMIC_FLAG_INIT ;


this is in #25748 .
@perrotta you may want to follow this PR because of the conflict.

perrotta · 2019-02-06T07:13:49Z

@Dr15Jones : after the merging of #25748 the conflict already pointed out by Slava inhttps://github.com//pull/25805#discussion_r252767589 becomes explicit
Since in that PR the same fix that you propose here was already implemented, you can resolve the conflict by simply reverting your commit 1999bdb here

This fixes a clang warning.

cmsbuild · 2019-02-06T14:18:45Z

The code-checks are being triggered in jenkins.

Dr15Jones · 2019-02-06T14:18:45Z

@perrotta all I had to do was rebase onto master and git automatically dropped the one commit I had that was conflicting with what is now in master.

cmsbuild · 2019-02-06T14:25:49Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-25805/8337

This PR adds an extra 16KB to repository

cmsbuild · 2019-02-06T14:26:24Z

Pull request #25805 was updated. @cmsbuild, @perrotta, @slava77 can you please check and sign again.

Dr15Jones · 2019-02-06T14:34:25Z

please test

cmsbuild · 2019-02-06T14:34:56Z

The tests are being triggered in jenkins.
https://cmssdt.cern.ch/jenkins/job/ib-any-integration/33020/console Started: 2019/02/06 15:36

cmsbuild · 2019-02-06T15:41:15Z

+1
Tested at: 95cdd6c
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25805/33020/summary.html

cmsbuild · 2019-02-06T15:41:20Z

Comparison job queued.

cmsbuild · 2019-02-06T17:01:34Z

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-25805/33020/summary.html

Comparison Summary:

No significant changes to the logs found
Reco comparison results: 4 differences found in the comparisons
DQMHistoTests: Total files compared: 32
DQMHistoTests: Total histograms compared: 3097440
DQMHistoTests: Total failures: 1
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3097242
DQMHistoTests: Total skipped: 197
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 0.0 KiB( 31 files compared)
Checked 133 log files, 14 edm output root files, 32 DQM output files

perrotta · 2019-02-06T17:07:27Z

+1

Technical
Jenkins tests pass

cmsbuild · 2019-02-06T17:08:00Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @davidlange6, @slava77, @smuzaffar, @fabiocos (and backports should be raised in the release meeting by the corresponding L2)

fabiocos · 2019-02-07T09:38:04Z

+1

cmsbuild added this to the CMSSW_10_5_X milestone Jan 30, 2019

cmsbuild added code-checks-pending comparison-pending orp-pending pending-signatures reconstruction-pending tests-pending labels Jan 30, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Jan 30, 2019

cmsbuild added tests-started and removed tests-pending labels Jan 30, 2019

cmsbuild added tests-approved and removed tests-started labels Jan 30, 2019

cmsbuild added comparison-available and removed comparison-pending labels Jan 30, 2019

slava77 reviewed Jan 31, 2019

View reviewed changes

Dr15Jones added 2 commits February 6, 2019 08:16

Removed unused variables inErrorChecker

c2d080f

This fixes a clang warning.

Remove unused function in PixelUnpackingRegions.cc

95cdd6c

This fixes a clang warning.

Dr15Jones force-pushed the clangSiPixelRawToDigi branch from 1999bdb to 95cdd6c Compare February 6, 2019 14:18

cmsbuild removed code-checks-approved comparison-available labels Feb 6, 2019

cmsbuild added comparison-pending tests-pending labels Feb 6, 2019

cmsbuild added code-checks-approved and removed code-checks-pending labels Feb 6, 2019

cmsbuild added tests-started and removed tests-pending labels Feb 6, 2019

cmsbuild added tests-approved and removed tests-started labels Feb 6, 2019

cmsbuild added comparison-available and removed comparison-pending labels Feb 6, 2019

cmsbuild added fully-signed reconstruction-approved and removed pending-signatures reconstruction-pending labels Feb 6, 2019

cmsbuild added orp-approved and removed orp-pending labels Feb 7, 2019

cmsbuild merged commit d7f23cb into cms-sw:master Feb 7, 2019

Dr15Jones deleted the clangSiPixelRawToDigi branch February 7, 2019 14:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix clang warnings in EventFilter/SiPixelRawToDigi #25805

Fix clang warnings in EventFilter/SiPixelRawToDigi #25805

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019 •

edited

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

slava77 Jan 31, 2019

perrotta commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

Dr15Jones commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

Dr15Jones commented Feb 6, 2019

cmsbuild commented Feb 6, 2019 •

edited

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

perrotta commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

fabiocos commented Feb 7, 2019

Fix clang warnings in EventFilter/SiPixelRawToDigi #25805

Fix clang warnings in EventFilter/SiPixelRawToDigi #25805

Conversation

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

Dr15Jones commented Jan 30, 2019

cmsbuild commented Jan 30, 2019 • edited

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

cmsbuild commented Jan 30, 2019

slava77 Jan 31, 2019

Choose a reason for hiding this comment

perrotta commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

Dr15Jones commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

Dr15Jones commented Feb 6, 2019

cmsbuild commented Feb 6, 2019 • edited

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

perrotta commented Feb 6, 2019

cmsbuild commented Feb 6, 2019

fabiocos commented Feb 7, 2019

cmsbuild commented Jan 30, 2019 •

edited

cmsbuild commented Feb 6, 2019 •

edited